Re: Review Request 110430: [Taskbar applet] Added actions to be perfomed on middle click

2013-05-14 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110430/#review32545 --- I am not in favour of this patch for a couple of reasons. First

Re: Review Request 110431: Improve battery monitor with multiple batteries

2013-05-14 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110431/#review32544 --- "I didn't know how to do this when it's inside a model" This s

PotD Headers

2013-05-14 Thread David Narvaez
Hi, Would it be a goog idea the following two headers from the kdeplasma-addons repository? dataengines/potd/plasma_potd_export.h dataengines/potd/potdprovider.h This would ease development of new providers. David E. Narváez ___ Plasma-devel mailing l

Re: Review Request 110430: [Taskbar applet] Added actions to be perfomed on middle click

2013-05-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110430/ --- (Updated May 14, 2013, 10:35 p.m.) Review request for kde-workspace and Pl

Review Request 110431: Improve battery monitor with multiple batteries

2013-05-14 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110431/ --- Review request for Plasma and Viranch Mehta. Description --- This pat

Re: Review Request 110389: Add "Configure" button to notifications that opens KNotify settings for the app that emitted the notification

2013-05-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110389/ --- (Updated May 14, 2013, 9:33 p.m.) Status -- This change has been mark

Re: Review Request 110389: Add "Configure" button to notifications that opens KNotify settings for the app that emitted the notification

2013-05-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110389/#review32533 --- This review has been submitted with commit b8d61a48f5e73784950

Re: Review Request 110406: Expose more battery properties to the Power Management dataengine

2013-05-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110406/ --- (Updated May 14, 2013, 9:29 p.m.) Status -- This change has been mark

Re: Review Request 110406: Expose more battery properties to the Power Management dataengine

2013-05-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110406/#review32532 --- This review has been submitted with commit 921d6822b7451c99323

Re: Review Request 110389: Add "Configure" button to notifications that opens KNotify settings for the app that emitted the notification

2013-05-14 Thread Kai Uwe Broulik
> On May 14, 2013, 6:46 p.m., Aaron J. Seigo wrote: > > code looks fine, the feature i think will be welcome by many. > > > > my only concern is how usable this will be on touch. (probably not very.) > > for Plasma Active 4 this is not a problem as it is using 4.10. We'll need > > to revisit t

Re: Using plasma enums from QML2

2013-05-14 Thread Marco Martin
On Tuesday 14 May 2013 17:53:18 you wrote: > > In a perfect world, yes. In the less perfect world we live in, it means > > more porting work. Not sure which is worse. I suppose, at least, that > > this kind of porting can be done with a script. > > unfortunately posting has to be dine anyways, sin

Re: Review Request 110389: Add "Configure" button to notifications that opens KNotify settings for the app that emitted the notification

2013-05-14 Thread Thomas Pfeiffer
> On May 14, 2013, 6:46 p.m., Aaron J. Seigo wrote: > > code looks fine, the feature i think will be welcome by many. > > > > my only concern is how usable this will be on touch. (probably not very.) > > for Plasma Active 4 this is not a problem as it is using 4.10. We'll need > > to revisit t

Re: kde-workspace and plasma2

2013-05-14 Thread Marco Martin
On Tuesday 14 May 2013 20:25:58 Aaron J. Seigo wrote: > Even porting a few of the plasmoids wouldn't be the worst of ideas. (I > expect the icon one to be interesting ...) Not everything needs to be > ported right now, however, especially not components that get frequent > activity. ok, so i'll ke

Re: Review Request 110413: Show in the tasks applet the activities a task is available on

2013-05-14 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110413/#review32522 --- a couple of minor issues, and then this should be ready to go!

Re: Review Request 110427: Allow Plasma::ConfigLoader to load default QColor values that contain alpha channel

2013-05-14 Thread Michał Dutkiewicz
> On May 14, 2013, 8:50 p.m., Aaron J. Seigo wrote: > > plasma/configloader.cpp, lines 204-205 > > > > > > '/' but then ',' > > > > which is it (and what color format saves like that?) True, I have no id

Re: Review Request 110427: Allow Plasma::ConfigLoader to load default QColor values that contain alpha channel

2013-05-14 Thread Michał Dutkiewicz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110427/ --- (Updated May 14, 2013, 8:55 p.m.) Review request for Plasma, Aaron J. Seig

Re: Review Request 110427: Allow Plasma::ConfigLoader to load default QColor values that contain alpha channel

2013-05-14 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110427/#review32521 --- plasma/configloader.cpp

Re: Review Request 110406: Expose more battery properties to the Power Management dataengine

2013-05-14 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110406/#review32520 --- Ship it! Ship It! - Aaron J. Seigo On May 12, 2013, 1:06 p.

Re: Review Request 110389: Add "Configure" button to notifications that opens KNotify settings for the app that emitted the notification

2013-05-14 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110389/#review32519 --- Ship it! code looks fine, the feature i think will be welcome

Re: Review Request 109965: Refactor assetimporters

2013-05-14 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109965/#review32516 --- Ship it! Ship It! - Aaron J. Seigo On May 12, 2013, 8:59 p.

Re: kde-workspace and plasma2

2013-05-14 Thread Aaron J. Seigo
On Tuesday, May 14, 2013 16:58:10 Marco Martin wrote: > the library/shell and scriptengine parts are growing to have the features > needed to have a complete shell. but for me is a bit different to do it > "blindly", i find a bit difficult to work on a framework without making at > the same time so

Review Request 110427: Allow Plasma::ConfigLoader to load default QColor values that contain alpha channel

2013-05-14 Thread Michał Dutkiewicz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110427/ --- Review request for Plasma, Aaron J. Seigo and Marco Martin. Description --

Re: Using plasma enums from QML2

2013-05-14 Thread Marco Martin
On Tuesday 14 May 2013 15:12:59 Aaron J. Seigo wrote: > On Sunday, May 12, 2013 13:14:23 Marco Martin wrote: > > plasma.topEdge (notice the lower case) that plasma object would be a > > fugly :/ i'm not happy with the overly long "PlasmaCore.Types.TopEdge", but > i guess that's the lesser of evil

Re: kde-workspace and plasma2

2013-05-14 Thread Marco Martin
On Tuesday 14 May 2013 15:28:27 Aaron J. Seigo wrote: > On Monday, May 13, 2013 15:10:41 Marco Martin wrote: > > * a kded that says what formfactor we are running on > > in the end the plasma part of kde-workspace should look like > > http://community.kde.org/Plasma/KdeWorkspaceRepoStructure > > (a

Re: Review Request 110411: Share data engine - install whole contents directories instead of separate files

2013-05-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110411/ --- (Updated May 14, 2013, 1:40 p.m.) Status -- This change has been mark

Re: Review Request 110411: Share data engine - install whole contents directories instead of separate files

2013-05-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110411/#review32502 --- This review has been submitted with commit 4affe9861f322f92187

Re: Review Request 110411: Share data engine - install whole contents directories instead of separate files

2013-05-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110411/#review32500 --- Ship it! Ship It! - Marco Martin On May 12, 2013, 5:45 p.m.

Re: it seems prototype inheritance is not supported in qtscript when developing a plasmoid, right? please tell me if you know, thanks advance.

2013-05-14 Thread Aaron J. Seigo
It is plain ecmascript, so yes, it is supported. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: UI refactor

2013-05-14 Thread Aaron J. Seigo
On Monday, May 13, 2013 20:10:38 Shantanu Tushar Jha wrote: > it will take some effort. Have you tried merging master into your branch? you usually do not want to merge master into a branch that will later be merged back into master as the resulting log in master will be less than pretty over ti

Re: there seems to be no dataengines or datasources can provide harddisk's temperature, right?

2013-05-14 Thread Aaron J. Seigo
On Tuesday, May 14, 2013 10:47:23 Mark wrote: > I did a quick search and couldn't find anything for you. The thing > that gets closest is perhaps the systemmonitor dataengine which does > something with sensors as well [1] yes, this has all the lmsensor data. -- Aaron J. Seigo signature.asc De

Re: kde-workspace and plasma2

2013-05-14 Thread Aaron J. Seigo
On Monday, May 13, 2013 15:10:41 Marco Martin wrote: > * a kded that says what formfactor we are running on > in the end the plasma part of kde-workspace should look like > http://community.kde.org/Plasma/KdeWorkspaceRepoStructure > (at least so was discussed in nuremberg) this is currently in the

Re: Using plasma enums from QML2

2013-05-14 Thread Aaron J. Seigo
On Sunday, May 12, 2013 13:14:23 Marco Martin wrote: > plasma.topEdge (notice the lower case) that plasma object would be a fugly :/ i'm not happy with the overly long "PlasmaCore.Types.TopEdge", but i guess that's the lesser of evils. > > > * Types name (or any other for what matters) is not p

Re: there seems to be no dataengines or datasources can provide harddisk's temperature, right?

2013-05-14 Thread Anant Kamath
My last year's GSoC project might be suitable : A plasmoid which displays the HDD temperature : http://quickgit.kde.org/?p=scratch%2Fkamath%2Fsmart_plasmoid.git which uses a dataengine based on this library http://quickgit.kde.org/?p=scratch%2Fkamath%2Fsolidsmart.git On 14 May 2013 14:25, Mark wr

it seems prototype inheritance is not supported in qtscript when developing a plasmoid, right? please tell me if you know, thanks advance.

2013-05-14 Thread bruce
___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: there seems to be no dataengines or datasources can provide harddisk's temperature, right?

2013-05-14 Thread Mark
On Tue, May 14, 2013 at 10:47 AM, Mark wrote: > I did a quick search and couldn't find anything for you. The thing > that gets closest is perhaps the systemmonitor dataengine which does > something with sensors as well [1] other then that a dedicated > temperature QML component (or dataengine) wou

Re: there seems to be no dataengines or datasources can provide harddisk's temperature, right?

2013-05-14 Thread Mark
I did a quick search and couldn't find anything for you. The thing that gets closest is perhaps the systemmonitor dataengine which does something with sensors as well [1] other then that a dedicated temperature QML component (or dataengine) would seem to be nice to have. Existing temperature monit