Re: Review Request 109965: Refactor assetimporters

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109965/ --- (Updated May 12, 2013, 8:59 p.m.) Review request for Plasma. Changes ---

Re: Review Request 109965: Refactor assetimporters

> On May 11, 2013, 9:51 a.m., Aaron J. Seigo wrote: > > licenseQuery, partnerQuery, languageQuery need to be changed to licenseId, > > partnerId and languageId. they return the ID of the license, partner and > > language. what they do internally is irrelevant. API must reflect what the > > API

Re: Review Request 109965: Refactor assetimporters

> On April 13, 2013, 2:12 a.m., Aaron J. Seigo wrote: > > assetimporters/projectgutenberg/src/gutenbergdatabase.cpp, lines 328-338 > > > > > > this can be done once and then the value cached now m_partnerId takes

Review Request 110411: Share data engine - install whole contents directories instead of separate files

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110411/ --- Review request for Plasma, Artur Duque de Souza and Sebastian Kügler. Desc

Re: Review Request 110389: Add "Configure" button to notifications that opens KNotify settings for the app that emitted the notification

> On May 12, 2013, 2:11 p.m., Heiko Tietze wrote: > > Nice feature, if it works overall. Is there a question for usability except > > the fact that we need guidelines on notification along with its > > configuration in general? Oh, yes guidelines, we indeed need them! Would you like to help? T

Re: Review Request 110389: Add "Configure" button to notifications that opens KNotify settings for the app that emitted the notification

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110389/#review32386 --- Nice feature, if it works overall. Is there a question for usab

Re: Review Request 110389: Add "Configure" button to notifications that opens KNotify settings for the app that emitted the notification

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110389/ --- (Updated May 12, 2013, 2:10 p.m.) Review request for Plasma and KDE Usabil

Review Request 110406: Expose more battery properties to the Power Management dataengine

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110406/ --- Review request for Plasma. Description --- Depends on Review 110384

Re: Using plasma enums from QML2

On Sunday 12 May 2013, Aaron J. Seigo wrote: > On Friday, May 10, 2013 19:44:09 Marco Martin wrote: > > After many experiments in varuious failing directions, i have the branch > > PlasmaTypesClass of palsma-framework > > de-duplication is terrific. > > it's still a draft state, i realize. the co