Re: Review Request 109967: Export KLocale flags to QML locale bindings correctly

2013-04-11 Thread Anant Kamath
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109967/ --- (Updated April 11, 2013, 10:48 p.m.) Status -- This change has been m

Re: Review Request 109967: Export KLocale flags to QML locale bindings correctly

2013-04-11 Thread Sebastian Kügler
> On April 11, 2013, 8:39 p.m., Sebastian Kügler wrote: > > Ship It! This patch needs forward porting to (the Frameworks5) plasma-framework repo. Can you do this, or would you rather have me do it? - Sebastian --- This is an automatic

Re: Review Request 109967: Export KLocale flags to QML locale bindings correctly

2013-04-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109967/#review30943 --- Ship it! Ship It! - Sebastian Kügler On April 11, 2013, 8:3

Re: Review Request 109967: Export KLocale flags to QML locale bindings correctly

2013-04-11 Thread Anant Kamath
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109967/ --- (Updated April 11, 2013, 8:30 p.m.) Review request for KDE Runtime and Pla

Re: QML Locale bindings not formatting time correctly

2013-04-11 Thread Anant Kamath
Okay so I guess this IS a bug. I fixed it by adding Q_FLAGS(TimeFormatOptions) in kde-runtime/plasma/declarativeimports/locale/locale_p.h and rebuilding. The QML code now works as expected. I file a review request for the same. -- Anant Kamath On 11 April 2013 15:53, Anant Kamath wrote: > So

Re: Outdated notifications bugs

2013-04-11 Thread Luiz Romário Santana Rios
Em qui 11 abr 2013, às 19:17:42, Marco Martin escreveu: > yes i think they can be safelly closed So, I suppose any bug in this search[1] can be closed as well? And I don't think I can close bugs, so, can any of you guys do it? Regards. --- [1] https://bugs.kde.org/buglist.cgi?list_id=583944&bug

Re: Outdated notifications bugs

2013-04-11 Thread Marco Martin
On Thursday 11 April 2013, Luiz Romário Santana Rios wrote: > Hello list. > > Looking through b.k.o, I found some bugs in the notification widget that > probably don't hold anymore, since it's been replaced by a QML version > since 4.10. Here are some examples: > > Version 4.6.1(!): https://bugs.

Outdated notifications bugs

2013-04-11 Thread Luiz Romário Santana Rios
Hello list. Looking through b.k.o, I found some bugs in the notification widget that probably don't hold anymore, since it's been replaced by a QML version since 4.10. Here are some examples: Version 4.6.1(!): https://bugs.kde.org/show_bug.cgi?id=256836 Version 4.7.4: https://bugs.kde.org/show_

Which settings should go in the settings dialog of a Plasmoid?

2013-04-11 Thread Thomas Pfeiffer
Hi Plasma and KDE Usability teams, the KDE Telepathy team is currently facing a decision which I think calls for being put into a broader context: Which settings should go in a settings dialog of a Plasmoid? Of course we have the Plasmoid-specific settings Keyboard Shortcut, Share and maybe some

Re: Review Request 109821: make the DvcsJob async

2013-04-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109821/ --- (Updated April 11, 2013, 10:28 a.m.) Status -- This change has been m

Re: Review Request 109821: make the DvcsJob async

2013-04-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109821/#review30905 --- This review has been submitted with commit c32a502181dbbacc34e

QML Locale bindings not formatting time correctly

2013-04-11 Thread Anant Kamath
Some functions in the QML Locale bindings (in KDE 4.10.1) seem to be ignoring some flags: For example-> This QML code: - Locale { id: locale } PlasmaComponents.Label { text: locale.formatLocaleTime( "11:12:13", Locale.TimeWithoutAmPm ) } --