Re: Review Request 109684: Make code python3 compatible.

2013-03-23 Thread Michael Jansen
On Sunday, March 24, 2013 12:49:11 AM Luca Beltrame wrote: > In data domenica 24 marzo 2013 00:45:46, Michael Jansen ha scritto: > > The we should for now do as i did for kross (another thing that has to be > > made python3 compatible) > > Rather than setting everything to false I would just exclu

Re: Review Request 109684: Make code python3 compatible.

2013-03-23 Thread Luca Beltrame
In data domenica 24 marzo 2013 00:45:46, Michael Jansen ha scritto: > The we should for now do as i did for kross (another thing that has to be > made python3 compatible) Rather than setting everything to false I would just exclude include_directories with the script engine if Py > 2 is found (m

Re: Review Request 109684: Make code python3 compatible.

2013-03-23 Thread Michael Jansen
On Saturday, March 23, 2013 11:37:18 PM Luca Beltrame wrote: > > On March 23, 2013, 11:35 p.m., Luca Beltrame wrote: > > > The issue is much deeper than this specific piece of code. In fact, > > > fixing this part will not make the code Py3 compatible. The real > > > problematic code is in PyKDE4,

Re: Review Request 109684: Make code python3 compatible.

2013-03-23 Thread Luca Beltrame
> On March 23, 2013, 11:35 p.m., Luca Beltrame wrote: > > The issue is much deeper than this specific piece of code. In fact, fixing > > this part will not make the code Py3 compatible. The real problematic code > > is in PyKDE4, to be precise the kpythonpluginfactory (kpythonpluginfactory/ >

Re: Review Request 109684: Make code python3 compatible.

2013-03-23 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109684/#review29772 --- The issue is much deeper than this specific piece of code. In f

Review Request 109684: Make code python3 compatible.

2013-03-23 Thread Michael Jansen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109684/ --- Review request for Plasma and Luca Beltrame. Description --- Make cod

Re: Review Request 109670: Minor fixes to assetimporters

2013-03-23 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109670/#review29771 --- Ship it! Ship It! - Aaron J. Seigo On March 23, 2013, 5:07

Review Request 109670: Minor fixes to assetimporters

2013-03-23 Thread Giorgos Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109670/ --- Review request for Plasma. Description --- Hello, * this patch fixes

Re: Review Request 109641: Fix border detection in Plasma dialogs

2013-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109641/#review29762 --- This review has been submitted with commit a88fec10e0ef2dd73f0

Re: Review Request 109340: Use default background colours for the konsolepreviewer

2013-03-23 Thread Giorgos Tsiapaliokas
> On March 15, 2013, 8:13 p.m., Giorgos Tsiapaliokas wrote: > > any updates on this one? > > Tianyu Zhu wrote: > Sorry, I've had a hectic couple of weeks (school, you know). I haven't > contributed to KDE before so I'll see what I can figure out from the wiki. >I haven't contributed to KDE

Re: Review Request 109500: Refactor of the savesystem

2013-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109500/ --- (Updated March 23, 2013, 3:58 p.m.) Status -- This change has been ma

Re: Review Request 109500: Refactor of the savesystem

2013-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109500/#review29758 --- This review has been submitted with commit e12d0c1e3aaccf49078

Re: Review Request 109605: Fix Plasmate loading local folders with the wrong API

2013-03-23 Thread Giorgos Tsiapaliokas
> On March 23, 2013, 2:25 p.m., Giorgos Tsiapaliokas wrote: > > Ship It! just make sure to follow this policy http://community.kde.org/Plasma/IntegrationBranches/GeneralPolicy - Giorgos --- This is an automatically generated e-mail. To

Re: Review Request 109605: Fix Plasmate loading local folders with the wrong API

2013-03-23 Thread Giorgos Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109605/#review29750 --- Ship it! Ship It! - Giorgos Tsiapaliokas On March 23, 2013,

Re: Review Request 109605: Fix Plasmate loading local folders with the wrong API

2013-03-23 Thread Yuen Hoe Lim
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109605/ --- (Updated March 23, 2013, 7:16 a.m.) Review request for Plasma. Changes -