Re: Review Request 105139: Plasmate: Add tabbox previewer

2013-03-14 Thread Kevin Kofler
> On March 14, 2013, 9:14 p.m., Kevin Kofler wrote: > > Unfortunately, the binary files (the .png images) are not contained in the > > diff, and were therefore created in the repository as 0-byte files! > > Antonis Tsiapaliokas wrote: > @kevin: > > Yes, that's correct, but i am usi

Re: Review Request 105139: Plasmate: Add tabbox previewer

2013-03-14 Thread Antonis Tsiapaliokas
> On March 14, 2013, 9:14 p.m., Kevin Kofler wrote: > > Unfortunately, the binary files (the .png images) are not contained in the > > diff, and were therefore created in the repository as 0-byte files! @kevin: Yes, that's correct, but i am using local branches for my patches. So i don't thin

Re: Review Request 105139: Plasmate: Add tabbox previewer

2013-03-14 Thread Kevin Kofler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105139/#review29232 --- Unfortunately, the binary files (the .png images) are not conta

Re: [kde-workspace] /: block until the lock windows are shown; prevents sleeping before locking

2013-03-14 Thread Oliver Henshaw
This might be a little too concise, but hopefully it should be clear if you have KSldApp::lock() in ksmserver/screenlocker/ksldapp.cpp up in front of you. Hopefully I haven't left out any important details. On 14 March 2013 11:18, Aaron Seigo wrote: > Git commit 62c2c398611b2e6ef6e1e38ed79bc9540

Re: Predictability in plasmapkg behavior

2013-03-14 Thread Aleix Pol
On Wed, Mar 13, 2013 at 8:50 PM, Aaron J. Seigo wrote: > On Wednesday, March 13, 2013 19:01:26 Aleix Pol wrote: > > - Assuming plasmoids is wrong, if we want plasmapkg to be for more things > > than plasmoids. > > Agreed .. patches welcome :) > > > - I'm unsure in what cases -t should be used. Is

Re: Predictability in plasmapkg behavior

2013-03-14 Thread Sebastian Kügler
On Wednesday, March 13, 2013 19:01:26 Aleix Pol wrote: > - Assuming plasmoids is wrong, if we want plasmapkg to be for more things > than plasmoids. I think it's fine to keep it as default, but maybe we want to check the servicetype in the metadata.desktop file and compare it with the type we a

[kde-workspace] /: block until the lock windows are shown; prevents sleeping before locking

2013-03-14 Thread Aaron Seigo
Git commit 62c2c398611b2e6ef6e1e38ed79bc9540fc02ec9 by Aaron Seigo. Committed on 14/03/2013 at 12:16. Pushed by aseigo into branch 'master'. block until the lock windows are shown; prevents sleeping before locking accomplished by: * synchronously calling desktopResized in the screen locker app