Re: Review Request: qml based kwin shadow

2013-01-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/#review25132 --- Ship it! the duplication tells me we should someday add a shar

Review Request: Port screenlocker greeter app away from Kephal

2013-01-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108318/ --- Review request for Plasma. Description --- Port screenlocker greeter

Re: Review Request: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

2013-01-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108308/ --- (Updated Jan. 10, 2013, 6:50 a.m.) Review request for kdelibs, kwin, Plasm

[KDE Bugtracking System] REMINDER: current Plasma regressions

2013-01-09 Thread bugzilla_noreply
Please find below a list of the current regressions reported for Plasma. This is a weekly reminder. This search was scheduled by myr...@kde.org. Plasma regressions -- Bug 202336: https://bugs.kde.org/show_bug.cgi?id=202336 Priority: NOR Severity: normal Platform: Gentoo

Re: Review Request: Use \n to split QML errors

2013-01-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108124/#review25121 --- This review has been submitted with commit 76a062b31b494b464ad

Re: Review Request: Use \n to split QML errors

2013-01-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108124/#review25120 --- This review has been submitted with commit ba0bbb3bcc80dcdd915

Re: Review Request: Translate \n into for error messages

2013-01-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108123/#review25119 --- This review has been submitted with commit b9aec0c85a7d3cc17ea

Re: krunner qml

2013-01-09 Thread Aleix Pol
On Wed, Jan 9, 2013 at 3:43 PM, Aaron J. Seigo wrote: > hi... > > in order to have a workspace ready for libplasma2, everything needs to be > done > in qml. there has been at least one attempt to get krunner QML-ified, > thanks to > Aleix Pol, and possibly others. > > a fair amount of internal wo

Re: Review Request: NepomukRunner: Redirect the 'nepomuk:/res/uuid' urls before opening them

2013-01-09 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108305/#review25100 --- Ship it! Please fix the coding style. I've pointed it out in t

Re: Re: C++11 for kde-workspaces

2013-01-09 Thread Martin Gräßlin
On Wednesday 09 January 2013 19:20:15 Ivan Čukić wrote: > Mind that the 'CMake stuff' will need magic hands of our resident CMake > experts before it goes anywhere near kdelibs. I'm also fine with it just going into kde-workspace. > > Ch! > > On 9 January 2013 17:17, Martin Gräßlin wrote: > > any

Re: Review Request: Do not clip away shadows in SlidingPopupsEffect

2013-01-09 Thread Xuetian Weng
> On Jan. 9, 2013, 12:51 p.m., Xuetian Weng wrote: > > Test with OpenGL + XRender, both side of screen popup tested, yakuake seems > > have no problem. All problem that I mentioned before is solved. I don't > > have dual screen setup for now.. may try it later. Ok, testing with dual screen, se

Re: C++11 for kde-workspaces

2013-01-09 Thread Ivan Čukić
Mind that the 'CMake stuff' will need magic hands of our resident CMake experts before it goes anywhere near kdelibs. Ch! On 9 January 2013 17:17, Martin Gräßlin wrote: > any further comments? If not I would like to see the CMake stuff go in very > soon :-) > > If anyone wonders why I am pushi

Review Request: NepomukRunner: Redirect the 'nepomuk:/res/uuid' urls before opening them

2013-01-09 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108305/ --- Review request for Dolphin, Nepomuk and Plasma. Description --- N

Re: Review Request: plasmoidviewer: respect --containment flag in sizing and scenerect

2013-01-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108284/#review25084 --- This review has been submitted with commit 53ade9705b4c42ccc98

Re: Review Request: port from radioButton*Checked to radioButtonChecked

2013-01-09 Thread Giorgos Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108128/ --- (Updated Jan. 9, 2013, 4:37 p.m.) Review request for Plasma. Changes ---

Re: Review Request: Use \n to split QML errors

2013-01-09 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108124/#review25081 --- Ship it! Hasn't this already been committed? If not, please KD

Re: Kickoff-QML in 4.10 ?

2013-01-09 Thread Sebastian Kügler
On Sunday, January 06, 2013 01:47:06 Aaron J. Seigo wrote: > On Thursday, December 27, 2012 22:36:01 you wrote: > > thanks for the statement. I've addressed most of the points. Of course we > > can't include kickoff-qml into KDE 4.10 anymore, the next target will be > > 4.11 then. > > cool; my sug

Re: Plasma2 sprint in March / April?

2013-01-09 Thread Sebastian Kügler
Hey, On Wednesday, January 02, 2013 20:21:18 Alex Fiestas wrote: > On Wednesday 02 January 2013 16:01:56 Sebastian Kügler wrote: > > I have an informal offer for hosting a Plasma2 sprint. The focus lie on > > Frameworks4, Qt5 and Wayland topics. > > > > Preliminary dates could be in March or April

Re: C++11 for kde-workspaces

2013-01-09 Thread Martin Gräßlin
any further comments? If not I would like to see the CMake stuff go in very soon :-) If anyone wonders why I am pushing for it: I want to make use of variadic templates to get xcb sane. Cheers Martin On Thursday 27 December 2012 17:11:42 Martin Gräßlin wrote: > Hi all, > > I want to suggest that

The Problems with Shadows in KWin explained

2013-01-09 Thread Martin Gräßlin
Hi all, I wanted to share/explain why the changes in Plasma Shadows caused regressions in (an unknown number of) KWin effects. For this I first want to give an outline of how the compositing works. As you are probably aware KWin consists of a window manager and a compositor interacting with ea

krunner qml

2013-01-09 Thread Aaron J. Seigo
hi... in order to have a workspace ready for libplasma2, everything needs to be done in qml. there has been at least one attempt to get krunner QML-ified, thanks to Aleix Pol, and possibly others. a fair amount of internal work was really called for, though, to make it as nice as it could/shou

Re: Review Request: port kdelib's tooltip shadow code to icontasks, and remove halo

2013-01-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108265/#review25066 --- This review has been submitted with commit 94d36fbb721c39becd5

Re: Review Request: fix random battery cumulative data error update upon resume

2013-01-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108280/#review25064 --- This review has been submitted with commit ac51d54be4c019398ad

Re: Review Request: fix random battery cumulative data error update upon resume

2013-01-09 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108280/#review25060 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 8, 2013, 10:29 p

Re: Review Request: port kdelib's tooltip shadow code to icontasks, and remove halo

2013-01-09 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108265/#review25059 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 8, 2013, 2:06 p.

Re: Review Request: port kdelib's tooltip shadow code to icontasks, and remove halo

2013-01-09 Thread Aaron J. Seigo
> On Jan. 9, 2013, 9:17 a.m., Mark Gaiser wrote: > > I cannot imagine that code duplication is the way to go here. Surely there > > is a smarter way that doesn't involve duplicating code. There where other > > duplicated code paths before in KDE like the tooltip stuff and the rules to > > blur

Re: Review Request: Do not clip away shadows in SlidingPopupsEffect

2013-01-09 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108255/#review25050 --- Test with OpenGL + XRender, both side of screen popup tested, y

Re: Review Request: port kdelib's tooltip shadow code to icontasks, and remove halo

2013-01-09 Thread Xuetian Weng
> On Jan. 9, 2013, 9:17 a.m., Mark Gaiser wrote: > > I cannot imagine that code duplication is the way to go here. Surely there > > is a smarter way that doesn't involve duplicating code. There where other > > duplicated code paths before in KDE like the tooltip stuff and the rules to > > blur

Re: Review Request: Plasmate: Display an error message when signingwidget is failing to generate a new key

2013-01-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108205/#review25046 --- This review has been submitted with commit c13e5af5a8b7703f03f

Re: Review Request: Plasmate: Remove PasswordAsker class

2013-01-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108207/#review25045 --- This review has been submitted with commit da2060045c1268f1798

Re: Review Request: move away the git related stuff from Timeline::loadTimeLine

2013-01-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108129/#review25044 --- This review has been submitted with commit b2706f18f3fca491c90

Re: Review Request: Do not clip away shadows in SlidingPopupsEffect

2013-01-09 Thread Martin Gräßlin
> On Jan. 9, 2013, 8:52 a.m., Kai Uwe Broulik wrote: > > Tested and works perfect except for that 1px overlapping shadow issue I > > mentioned earlier but it now only appears in the last bits of the sliding > > out animation, and in the first bits of the sliding back in animation. > > Martin G

Re: Review Request: port branchdialog to KInputDialog

2013-01-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108125/#review25041 --- This review has been submitted with commit 2fe901d4b782d65b239

Re: Review Request: port internal pointer to data query

2013-01-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108126/#review25039 --- This review has been submitted with commit f7e811b488f206e6324

Re: Review Request: support svg and svgz files in imageloader

2013-01-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108127/#review25040 --- This review has been submitted with commit 44c0be7520f57c0a80a

Problems in activity connection

2013-01-09 Thread Marco Martin
Hi all, recently reviewing bugs in Plasma Active i seen that the "connect to activity" feature doesn't work at all anymore.. but it actually stopped working in the desktop as well, and seem is broken from all possible uis: the built in ui in active, the one in slc and the context menu in dolphin

Re: Review Request: port kdelib's tooltip shadow code to icontasks, and remove halo

2013-01-09 Thread Mark Gaiser
> On Jan. 9, 2013, 9:17 a.m., Mark Gaiser wrote: > > I cannot imagine that code duplication is the way to go here. Surely there > > is a smarter way that doesn't involve duplicating code. There where other > > duplicated code paths before in KDE like the tooltip stuff and the rules to > > blur

Re: Review Request: Do not clip away shadows in SlidingPopupsEffect

2013-01-09 Thread Kai Uwe Broulik
> On Jan. 9, 2013, 8:52 a.m., Kai Uwe Broulik wrote: > > Tested and works perfect except for that 1px overlapping shadow issue I > > mentioned earlier but it now only appears in the last bits of the sliding > > out animation, and in the first bits of the sliding back in animation. > > Martin G

Re: Review Request: Do not clip away shadows in SlidingPopupsEffect

2013-01-09 Thread Martin Gräßlin
> On Jan. 9, 2013, 8:52 a.m., Kai Uwe Broulik wrote: > > Tested and works perfect except for that 1px overlapping shadow issue I > > mentioned earlier but it now only appears in the last bits of the sliding > > out animation, and in the first bits of the sliding back in animation. I did not se

Re: Review Request: plasmoidviewer: respect --containment flag in sizing and scenerect

2013-01-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108284/#review25033 --- Ship it! like the idea - Marco Martin On Jan. 9, 2013, 4:22

Re: Review Request: port kdelib's tooltip shadow code to icontasks, and remove halo

2013-01-09 Thread Cedric Bellegarde
> On Jan. 9, 2013, 9:17 a.m., Mark Gaiser wrote: > > I cannot imagine that code duplication is the way to go here. Surely there > > is a smarter way that doesn't involve duplicating code. There where other > > duplicated code paths before in KDE like the tooltip stuff and the rules to > > blur

Re: Review Request: port kdelib's tooltip shadow code to icontasks, and remove halo

2013-01-09 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108265/#review25031 --- I cannot imagine that code duplication is the way to go here. S

Re: Review Request: Do not clip away shadows in SlidingPopupsEffect

2013-01-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108255/#review25030 --- Tested and works perfect except for that 1px overlapping shadow

Re: Review Request: Move IconItem into MouseArea

2013-01-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107886/#review25029 --- This review has been submitted with commit dbab2b3fdcf609489b7