Re: Review Request: Declarative bindings for ToolBox

2012-11-20 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107150/#review22273 --- Documentation for this review is now at http://techbase.kde.o

Re: Review Request: Containments expose an AppletContainer

2012-11-20 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106817/#review22272 --- Documentation for these patches is available at: http://techba

Re: Homerun sources and Plasma runners

2012-11-20 Thread Aaron J. Seigo
On Tuesday, November 20, 2012 18:12:47 Aurélien Gâteau wrote: > First, I am convinced using Qt models is the right API design for Homerun. I nobody is saying "don't use Qt models in homerun". the question is which of the following makes sense: * AbstractRunner should be a model (BIC) * AbstractR

Re: Homerun sources and Plasma runners

2012-11-20 Thread Aurélien Gâteau
Spent yesterday evening trying to think about this topic from all edges. First, I am convinced using Qt models is the right API design for Homerun. I have a very hard time giving up on them for the sake of not breaking source compatibility, to the point where I think it is better to do a clean b

Review Request: simplify the qinstallmsghandler code

2012-11-20 Thread Giorgos Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107395/ --- Review request for Plasma. Description --- Simplifies the qinstallmsg

Re: Review Request: kconfigxteditor refactor

2012-11-20 Thread Giorgos Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107394/ --- (Updated Nov. 20, 2012, 2:33 p.m.) Review request for Plasma. Changes --

Review Request: kconfigxteditor refactor

2012-11-20 Thread Giorgos Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107394/ --- Review request for Plasma. Description --- What has been done in the

Re: Review Request: Show a album cover in the track view if a cover is available. At the moment only a placeholder is displayed.

2012-11-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107325/#review22259 --- This review has been submitted with commit ee21f79456233a607db

Re: Icon sizes on panel vs. SystemSettings

2012-11-20 Thread Aaron J. Seigo
On Monday, November 19, 2012 20:17:44 Albert Astals Cid wrote: > Forwarding to plasma-devel where people with an opinion probably live. > > I'd suggest just killing that config option, been broken for all of the 4.x > live. while it is no longer used as the strict definition of what size icons wi