Review Request: Reduce verbosity when running a QML-based plasmoid

2012-11-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107261/ --- Review request for Plasma and Marco Martin. Description --- Right now

Re: KDEREVIEW: share like connect and plasmate

2012-11-08 Thread Antonis Tsiapaliokas
> > Did you actually understand what I'm referring to? > I guess that we all agree that we should replace the QDialog with the KPasswordDialog (right?). If so, how can we do that? Even if someone doesn't have the pinentry-qt4, then the pinentry (CL) is opening. And i wasn't able to remove the pine

Re: Review Request: Port the Calculator applet to QML

2012-11-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107001/#review21657 --- This review has been submitted with commit 08960f71610ffd869a7

Re: KDEREVIEW: share like connect and plasmate

2012-11-08 Thread Aaron J. Seigo
On Thursday, November 8, 2012 20:06:10 Antonis Tsiapaliokas wrote: > > - PasswordAsker sounds like could be implemented on top of > > KPasswordDialog > > gpgme is using pinetry-qt4 for password prompt, i don't think that we > should use the KPasswordDialog. gpgme does this because pinentry-qt4 is

Re: KDEREVIEW: share like connect and plasmate

2012-11-08 Thread Pino Toscano
Alle giovedì 8 novembre 2012, Antonis Tsiapaliokas ha scritto: > > - PasswordAsker sounds like could be implemented on top of > > KPasswordDialog > > gpgme is using pinetry-qt4 for password prompt, i don't think that we > should use the KPasswordDialog. Did you actually understand what I'm referr

Re: KDEREVIEW: share like connect and plasmate

2012-11-08 Thread Antonis Tsiapaliokas
> - PasswordAsker sounds like could be implemented on top of > KPasswordDialog > gpgme is using pinetry-qt4 for password prompt, i don't think that we should use the KPasswordDialog. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Review Request: Plasmate: Remove Python support for konsole previewer

2012-11-08 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107209/#review21628 --- Ship it! Good to go :) - Sebastian Kügler On Nov. 8, 2012,

Re: Review Request: Plasmate: Remove Python support for konsole previewer

2012-11-08 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107209/ --- (Updated Nov. 8, 2012, 2:05 p.m.) Review request for Plasma. Changes ---

Re: Review Request: porting comic plasmoid to qml

2012-11-08 Thread Reza Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107192/ --- (Updated Nov. 8, 2012, 12:47 p.m.) Review request for Plasma. Changes --

Re: Review Request: libs/mediacenter/CMakeLists.txt: find Taglib properly

2012-11-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107247/#review21623 --- This review has been submitted with commit 631d372c411f04bc086

Re: Review Request: Port the Calculator applet to QML

2012-11-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107001/#review21622 --- Ship it! Ship It! - Marco Martin On Nov. 6, 2012, 11:36 p.m

Re: Review Request: Port the Calculator applet to QML

2012-11-08 Thread Romário Rios
> On Nov. 8, 2012, 9:33 a.m., Marco Martin wrote: > > style is quite ok to me now. > > functions could still be changed to > > > > function foo() > > { > > ... > > } > > Aaron J. Seigo wrote: > actually, the style was finally updated to: > > function foo() { > } > > so

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-08 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107160/#review21618 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 7, 2012, 3:20 p.

Re: Review Request: Port the Calculator applet to QML

2012-11-08 Thread Marco Martin
> On Nov. 8, 2012, 9:33 a.m., Marco Martin wrote: > > style is quite ok to me now. > > functions could still be changed to > > > > function foo() > > { > > ... > > } > > Aaron J. Seigo wrote: > actually, the style was finally updated to: > > function foo() { > } > > so

Re: Review Request: Port the Calculator applet to QML

2012-11-08 Thread Aaron J. Seigo
> On Nov. 8, 2012, 9:33 a.m., Marco Martin wrote: > > style is quite ok to me now. > > functions could still be changed to > > > > function foo() > > { > > ... > > } actually, the style was finally updated to: function foo() { } so no need to adjust this :) - Aaron J.

Re: Review Request: Port the Calculator applet to QML

2012-11-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107001/#review21614 --- style is quite ok to me now. functions could still be changed t