Re: Review Request: Kickoff-qml fixes

2012-10-24 Thread David Edmundson
> On Oct. 24, 2012, 9:16 p.m., Sebastian Kügler wrote: > > plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml, line 109 > > > > > > Why remove this fade in animation? > > David Edmundson wrote: >

Re: Review Request: Kickoff-qml fixes

2012-10-24 Thread David Edmundson
> On Oct. 24, 2012, 9:16 p.m., Sebastian Kügler wrote: > > plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml, line 109 > > > > > > Why remove this fade in animation? Because as one of the other pat

Re: Review Request: Containments expose an AppletContainer

2012-10-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106817/#review20826 --- This review has been submitted with commit 347f21341d4eef93268

Re: Review Request: Kickoff-qml fixes

2012-10-24 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107026/#review20823 --- Ship it! One issue (inline), otherwise it looks good. plasma

Testing several plasmoid instances at the same time

2012-10-24 Thread Michał 'rysiek' Woźniak
Hi there, I am writing a plasmoid that is supposed to have drag and drop support - but am unable to test it efficiently with plasmoidviewer, as I have not found a way to display several instances of the same plasmoid in the same containment so that I could drag and drop between them. Any hints

Re: using device targets in qml plasmoids

2012-10-24 Thread Christoph Feck
On Wednesday 24 October 2012 13:51:03 Aaron J. Seigo wrote: > if "tablet" IS "touch", then we don't need a separate set, right? Please do not forget Tablet PC systems that use a stylus instead of touch. So it would work like using a mouse (precision, hover function, multiple buttons), but still

Re: Review Request: Containments expose an AppletContainer

2012-10-24 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106817/#review20818 --- Ship it! i think this is a good approach. only thing it can w

Re: Review Request: Fix KRunner's 'spell in foreign language' feature

2012-10-24 Thread Simeon Bird
> On Oct. 11, 2012, 12:01 a.m., Simeon Bird wrote: > > Does anyone have any objections? Given that the current behaviour is 'crash > > krunner when invoked' I feel I can't do much damage with this... Ok, it seems no-one has any objections (or indeed any interest). So pending any comments, I'll

Review Request: Kickoff-qml fixes

2012-10-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107026/ --- Review request for Plasma. Description --- If an application has no g

Re: kickoff qml

2012-10-24 Thread David Edmundson
Using bugzilla to track something not in master is not a good idea. It makes it impossible to identify what bugs are actually present in the product being shipped. Which is why I asked :) David ___ Plasma-devel mailing list Plasma-devel@kde.org https://

Re: using device targets in qml plasmoids

2012-10-24 Thread Sebastian Kügler
On Wednesday, October 24, 2012 16:36:35 Aaron J. Seigo wrote: > On Wednesday, October 24, 2012 16:09:23 Sebastian Kügler wrote: > > By the way, something notmart and I discussed a few days ago ... it would > > be handy if we had the input method ("touch", ...) accessible from the > > QML > another

Re: using device targets in qml plasmoids

2012-10-24 Thread Aaron J. Seigo
On Wednesday, October 24, 2012 16:09:23 Sebastian Kügler wrote: > By the way, something notmart and I discussed a few days ago ... it would be > handy if we had the input method ("touch", ...) accessible from the QML another approach would be to put your touch specific bits into javascript files t

Re: using device targets in qml plasmoids

2012-10-24 Thread Sebastian Kügler
On Wednesday, October 24, 2012 15:35:39 Aaron J. Seigo wrote: > On Wednesday, October 24, 2012 14:58:32 Sebastian Kügler wrote: > > I've also found that I don't need touch-specific stuff in the app code > > itself, the input specific things are already sorted in PlasmaComponents, > > using those, I

Re: Stackfolder inclusion to 4.10 [attempt#2]

2012-10-24 Thread Andreas Demmer
Hi Ural! > I've added shadows for items text using QGraphicsDropShadowEffect. Much more readable now, great. Still it should obey the theme text color which is black instead of while. See sebas suggestion: > Doesn't look like it's using the correct color from the theme > (Theme::textColor), o

Re: using device targets in qml plasmoids

2012-10-24 Thread Aaron J. Seigo
On Wednesday, October 24, 2012 14:58:32 Sebastian Kügler wrote: > I've also found that I don't need touch-specific stuff in the app code > itself, the input specific things are already sorted in PlasmaComponents, > using those, I didn't need a single touch-specific widget. So input is > solved at t

Re: Review Request: Possibility to change an element ID of svg image in IconWidget

2012-10-24 Thread Dmitry Ashkadov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107017/ --- (Updated Oct. 24, 2012, 1:02 p.m.) Review request for kdelibs and Plasma.

Re: using device targets in qml plasmoids

2012-10-24 Thread Sebastian Kügler
On Wednesday, October 24, 2012 13:58:19 Aaron J. Seigo wrote: > On Wednesday, October 24, 2012 12:16:37 Sebastian Kügler wrote: > > On Wednesday, October 24, 2012 11:41:17 Aaron J. Seigo wrote: > > > thoughts? > > > > I think screensize/layout and input method should stay separate things. > > agre

Re: Stackfolder inclusion to 4.10 [attempt#2]

2012-10-24 Thread Ural Mullabaev
Hi Andreas! > I would also suggest to give the label text at least some shadows since the > current white is somewhat hard to read: I've added shadows for items text using QGraphicsDropShadowEffect. > > Resizing popup window to contents of folder is our feature. [...] > > I think, we can make sp

Re: using device targets in qml plasmoids

2012-10-24 Thread Marco Martin
On Wednesday 24 October 2012, Aaron J. Seigo wrote: > On Wednesday, October 24, 2012 12:01:35 Marco Martin wrote: > > in practiche i see a bit of difficulty for components: > > basically we have to have an entire installed copy of components for each > > target, so right now there is a complete set

Re: using device targets in qml plasmoids

2012-10-24 Thread Aaron J. Seigo
On Wednesday, October 24, 2012 12:16:37 Sebastian Kügler wrote: > On Wednesday, October 24, 2012 11:41:17 Aaron J. Seigo wrote: > > thoughts? > > Not quite happy with it, with my experience from the microblog app. There, > the orthogonal input / layout makes complete sense, as you get the > followi

Re: using device targets in qml plasmoids

2012-10-24 Thread Aaron J. Seigo
On Wednesday, October 24, 2012 12:01:35 Marco Martin wrote: > in practiche i see a bit of difficulty for components: > basically we have to have an entire installed copy of components for each > target, so right now there is a complete set for desktop a complete set for > touch, adding more, or sub

Re: plans for Plasma Desktop default containment in QML

2012-10-24 Thread Aaron J. Seigo
On Wednesday, October 24, 2012 11:39:59 Marco Martin wrote: > about qml containments, a thing that is not uber pretty that i encountered > working on the one for active is that while plasmoids have only a limited > acces to theyr Applet* trough AppletInterface, plasmoids have direct access > to App

Re: Stackfolder inclusion to 4.10 [attempt#2]

2012-10-24 Thread Sebastian Kügler
On Tuesday, October 23, 2012 14:53:43 Andreas Demmer wrote: > I would also suggest to give the label text at least some shadows since the > current white is somewhat hard to read: > > http://wstaw.org/m/2012/10/23/plasma-desktopr24762.png Doesn't look like it's using the correct color from the t

Re: plans for Plasma Desktop default containment in QML

2012-10-24 Thread Sebastian Kügler
On Monday, October 22, 2012 13:33:45 Sebastian Kügler wrote: > My overall thinking is that I'd like the infrastructural work to be complete > for the 4.10 release (which seems achievable to me if we don't run into > architectural problems) so that Plasma 4.10 brings everything needed to run > full-

Re: Review Request: Possibility to change an element ID of svg image in IconWidget

2012-10-24 Thread Dmitry Ashkadov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107017/ --- (Updated Oct. 24, 2012, 10:50 a.m.) Review request for kdelibs and Plasma.

Re: using device targets in qml plasmoids

2012-10-24 Thread Sebastian Kügler
On Wednesday, October 24, 2012 11:41:17 Aaron J. Seigo wrote: > thoughts? Not quite happy with it, with my experience from the microblog app. There, the orthogonal input / layout makes complete sense, as you get the following combinations: touch / widget: perfect for smartphone screen, using

Re: plans for Plasma Desktop default containment in QML

2012-10-24 Thread Sebastian Kügler
Hey, On Wednesday, October 24, 2012 11:39:59 Marco Martin wrote: > On Monday 22 October 2012, Sebastian Kügler wrote: > > being merged in the process), some are things that we have been shipping > > in the MobileComponents QML module for some time. (MobileComponents has > > somehow grown to be a d

Re: using device targets in qml plasmoids

2012-10-24 Thread Marco Martin
On Wednesday 24 October 2012, Aaron J. Seigo wrote: > hi ... > > i think it is time that we started using PLASMA_CUSTOM_PREFIX_PATHS and > KDE_PLASMA_COMPONENTS_PLATFORM. what do they do, you ask? :) we definitely need a standard hyerarchy to have it work reliably > the first one adds additional

using device targets in qml plasmoids

2012-10-24 Thread Aaron J. Seigo
hi ... i think it is time that we started using PLASMA_CUSTOM_PREFIX_PATHS and KDE_PLASMA_COMPONENTS_PLATFORM. what do they do, you ask? :) the first one adds additional paths to plasmoid packages. the intended use is to define the current device target in a way that is largely transparent to t

Re: plans for Plasma Desktop default containment in QML

2012-10-24 Thread Marco Martin
On Monday 22 October 2012, Sebastian Kügler wrote: > being merged in the process), some are things that we have been shipping > in the MobileComponents QML module for some time. (MobileComponents has > somehow grown to be a dumping ground for "stuff that didn't fit well > elsewhere", and we're in t

Re: slc menu

2012-10-24 Thread Aaron J. Seigo
On Monday, October 22, 2012 19:30:02 Marco Martin wrote: > * just get rid of context menus in active: long tap selects an icon, then > slc menus are available from the usual place in the panel +1 to this from me. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message pa

Re: slc repo as dependency

2012-10-24 Thread Aaron J. Seigo
On Monday, October 22, 2012 19:27:18 Marco Martin wrote: > Hi all, > since freeze is looming, if we want to use slc in 4.10 by default, its > repository should become part of sc and be a dependency of kde-workspace (if > a default applet) this is actually not necessary: desktop scripting supports

Re: kickoff qml

2012-10-24 Thread Aaron J. Seigo
On Tuesday, October 23, 2012 21:16:41 David Edmundson wrote: > Marco, where do you want bug reports / tracking what needs to be done. use the normal places: bugs.kde.org, community.kde.org, this mailing list, etc -- Aaron J. Seigo signature.asc Description: This is a digitally signed message pa

Re: plans for Plasma Desktop default containment in QML

2012-10-24 Thread Aaron J. Seigo
On Monday, October 22, 2012 17:19:32 todd rme wrote: > Can you submit it to kde-look.org in the meantime? Does plasma > support installing containments through GHNS? There has been no such integration yet; all the client-side stuff is there (e.g. plasmapkg), but there is no scripted containments

Review Request: Possibility to change an element ID of svg image in IconWidget

2012-10-24 Thread Dmitry Ashkadov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107017/ --- Review request for Plasma. Description --- New System tray uses IconW

Re: Stackfolder inclusion to 4.10 [attempt#2]

2012-10-24 Thread Andreas Demmer
Hi Ural! > Resizing popup window to contents of folder is our feature. [...] > I think, we can make special version for KDE. I do not quite understand. Does this mean, that stack folders are a unique feature of your distro? At least the animated version? It would be really cool to share the ani