Re: Review Request: reuse knewstuff's itemsview class to provide smooth scrolling in wallpaper configuration screen

2012-09-22 Thread Reza Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106536/ --- (Updated Sept. 23, 2012, 2:19 a.m.) Review request for Plasma. Changes -

Re: Review Request: reuse knewstuff's itemsview class to provide smooth scrolling in wallpaper configuration screen

2012-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106536/#review19345 --- Run "git add " to make your new files appear in a diff. Also i

Review Request: reuse knewstuff's itemsview class to provide smooth scrolling in wallpaper configuration screen

2012-09-22 Thread Reza Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106536/ --- Review request for Plasma. Description --- This patch add smoothscrol

Re: plasmoid configuration using kconfigxt

2012-09-22 Thread Reza Shah
Hi Aaron, I forgot about the deletion. In plasma-desktop-appletrc,the plasmoid configuration is grouped like below: [Containments][8][Applets][26][Configuration] showComicTitle=true And in plasma-desktoprc, the same configuration is grouped in 'Appearance' (i'm using this in .kcfg file). [Appear

Re: Review Request: smooth scroll by mousewheel in SystemSettings

2012-09-22 Thread Ben Cooksley
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106523/#review19333 --- Ship it! Ship It! - Ben Cooksley On Sept. 21, 2012, 11:26 a

Re: Review Request: smooth scroll by mousewheel in SystemSettings

2012-09-22 Thread David Edmundson
> On Sept. 21, 2012, 11:38 a.m., Ben Cooksley wrote: > > systemsettings/icons/CategorizedView.cpp, line 51 > > > > > > I don't know the specifics of the bug which is being worked around, but > > would it not be more

Re: plasmoid configuration using kconfigxt

2012-09-22 Thread Aaron J. Seigo
On Saturday, September 22, 2012 09:04:23 Reza Shah wrote: > I changed the configuration to kconfigxt, but now the settings are > keep inside plasma-desktoprc. Is this expected behavior? Yes, if you are doing it from a C++ plugin, this is exactly what will happen. >From a QML/JS plugin it should do

Re: Review Request: Fix repositioning the toolbox when the widgets are locked

2012-09-22 Thread Ralf Jung
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106457/#review19292 --- I'd appreciate if someone could have a look at this. If you don

Re: Review Request: Fix panel redraw after screen resize

2012-09-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106519/#review19287 --- This review has been submitted with commit d6de898bee50f923074

Re: Review Request: Fix panel redraw after screen resize

2012-09-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106519/#review19286 --- This review has been submitted with commit 2fe20079a8cdeef325c