Re: Review Request: make plasmate able to load a project in the second time

2012-09-18 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106479/#review19136 --- mainwindow.cpp

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-18 Thread Marco Martin
> On Sept. 18, 2012, 10:13 p.m., Sebastian Kügler wrote: > > Patch looks good now, thanks a lot! > > > > Please commit it to KDE/4.9 and master. > > Sebastian Kügler wrote: > Ah, crap. I missed your question about the possible BIC issue. Can > someone answer this question? > > """

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-18 Thread Sebastian Kügler
> On Sept. 18, 2012, 10:13 p.m., Sebastian Kügler wrote: > > Patch looks good now, thanks a lot! > > > > Please commit it to KDE/4.9 and master. Ah, crap. I missed your question about the possible BIC issue. Can someone answer this question? """ Is it okay to remove a no longer needed overloa

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-18 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106441/#review19132 --- Ship it! Patch looks good now, thanks a lot! Please commit it

Re: Git policy for kde-baseapps?

2012-09-18 Thread David Faure
On Wednesday 12 September 2012 13:22:48 Frank Reininghaus wrote: > 1. Before a commit, which is not a merge, is pushed to either the > stable branch or master, run 'git pull --rebase'. If the remote branch > has moved on since the last pull, this prevents the creation of a > superfluous and possibl

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-18 Thread Ralf Jung
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106441/ --- (Updated Sept. 18, 2012, 5:40 p.m.) Review request for Plasma. Changes -

Re: Review Request: Make it possible to configure a wallpaper from the viewer

2012-09-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106495/#review19112 --- This review has been submitted with commit b223f16d592e9e78ac6

Re: Review Request: Make it possible to configure a wallpaper from the viewer

2012-09-18 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106495/#review19111 --- Ship it! Added a few style comments, and a translation improve

Re: Review Request: Make it possible to configure a wallpaper from the viewer

2012-09-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106495/#review19110 --- Ship it! seems straightforward plasma/generic/tools/wallpape

Review Request: Make it possible to configure a wallpaper from the viewer

2012-09-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106495/ --- Review request for Plasma. Description --- Extend the plasmawallpaper

Re: Review Request: Device notifier: fix free space information

2012-09-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106490/#review19106 --- This review has been submitted with commit b7c7b592e9e48146aa2

Re: Review Request: Device notifier: fix free space information

2012-09-18 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106490/#review19105 --- Ship it! Ship It! - Sebastian Kügler On Sept. 18, 2012, 12:

Review Request: Device notifier: fix free space information

2012-09-18 Thread Alberto Villa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106490/ --- Review request for Plasma and Marco Martin. Description --- The devic

Re: System tray

2012-09-18 Thread Aaron J. Seigo
On Tuesday, September 18, 2012 08:12:37 Daniel Nicoletti wrote: > 2012/9/18 Aaron J. Seigo : > > On Tuesday, September 18, 2012 10:58:32 Marco Martin wrote: > >> - for the popup as just icons: not overly strong opinion, but I tend to > >> prefer using text as well. > > > > agreed. it makes it clea

Re: System tray

2012-09-18 Thread Michał 'rysiek' Woźniak
Dnia wtorek, 18 września 2012 o 13:12:37 Daniel Nicoletti napisał(a): > 2012/9/18 Aaron J. Seigo : > > On Tuesday, September 18, 2012 10:58:32 Marco Martin wrote: > >> - for the popup as just icons: not overly strong opinion, but I > >> tend to prefer using text as well. > > > > agreed. it makes i

Re: System tray

2012-09-18 Thread Marco Martin
On Tuesday 18 September 2012, Daniel Nicoletti wrote: > 2012/9/18 Aaron J. Seigo : > > On Tuesday, September 18, 2012 10:58:32 Marco Martin wrote: > >> - for the popup as just icons: not overly strong opinion, but I tend to > >> prefer using text as well. > > > > agreed. it makes it clearer what e

Re: System tray

2012-09-18 Thread Daniel Nicoletti
2012/9/18 Aaron J. Seigo : > On Tuesday, September 18, 2012 10:58:32 Marco Martin wrote: >> - for the popup as just icons: not overly strong opinion, but I tend to >> prefer using text as well. > > agreed. it makes it clearer what each icon is, but also gives a much bigger > hit area and allows the

Re: System tray

2012-09-18 Thread Aaron J. Seigo
On Tuesday, September 18, 2012 10:58:32 Marco Martin wrote: > - for the popup as just icons: not overly strong opinion, but I tend to > prefer using text as well. agreed. it makes it clearer what each icon is, but also gives a much bigger hit area and allows them to be easily scanned (a grid is d

Re: Notifications-future, a recap

2012-09-18 Thread Dario Freddi
(readded frameworks, the topic ping-pongs) 2012/9/18 Aaron J. Seigo : > On Monday, September 17, 2012 20:40:33 Dario Freddi wrote: >> it's pretty much on the board :) just that 90% of this will happen in >> the background (server), whereas handlers will just take care of >> showing a model and a s

Re: Notifications-future, a recap

2012-09-18 Thread Aaron J. Seigo
On Monday, September 17, 2012 20:40:33 Dario Freddi wrote: > it's pretty much on the board :) just that 90% of this will happen in > the background (server), whereas handlers will just take care of > showing a model and a set of events. The aim is to make the client API > as simple as possible and

Re: System tray

2012-09-18 Thread Marco Martin
On Tuesday 18 September 2012, Dmitry wrote: > Hello, Marco! > > Could you try a system tray from plasma/dmitrya/systemtray-qml branch of > kde-workspace? What do you think about popup window? Maybe will it > better if icons in popup are placed like a grid? Hi, I just tried it, i must say it's loo

System tray

2012-09-18 Thread Dmitry
Hello, Marco! Could you try a system tray from plasma/dmitrya/systemtray-qml branch of kde-workspace? What do you think about popup window? Maybe will it better if icons in popup are placed like a grid? Thank you! ___ Plasma-devel mailing list Plasm