Re: Review Request: Config cleanup on removeActivity

2012-08-26 Thread Ivan Čukić
> On Aug. 27, 2012, 12:42 a.m., Lamarque Vieira Souza wrote: > > Ship It! Which branch is this, since it is not master as specified? - Ivan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r

Re: Review Request: Config cleanup on removeActivity

2012-08-26 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106097/#review18065 --- Ship it! Ship It! - Lamarque Vieira Souza On Aug. 20, 2012,

Re: Review Request: Kickoff-Widget: Add Key_Tab support for navigation from search Bar (4.8)

2012-08-26 Thread Lamarque Vieira Souza
> On Aug. 26, 2012, 7:50 a.m., Greg T wrote: > > besides the points mentioned in review 106125, you have to remember that > > KDE 4.8 is already EOL and there will be no more bugfix release (i.e. > > 4.8.6). > > Richard Stockton wrote: > Yes, but I was asked to put it on the 4.8 tree in ca

Re: Review Request: Weather Forecast QML port

2012-08-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106225/#review18054 --- Looks like a very good start. Comments below. applets/weather

Re: Review Request: LCD Weather Station QML port

2012-08-26 Thread Luis Gabriel Lima
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106226/ --- (Updated Aug. 26, 2012, 8:06 p.m.) Review request for Plasma and Marco Mar

Review Request: LCD Weather Station QML port

2012-08-26 Thread Luis Gabriel Lima
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106226/ --- Review request for Plasma and Marco Martin. Description --- This patc

Review Request: Weather Forecast QML port

2012-08-26 Thread Luis Gabriel Lima
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106225/ --- Review request for Plasma and Marco Martin. Description --- This patc

Review Request: plasmoid digital-clock - layout bug in small vertical panels

2012-08-26 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106223/ --- Review request for Plasma. Description --- Fix this little bug they s

Re: Review Request: Usability: Add keyboard navigation to Kickoff GUI (within and among all Views)

2012-08-26 Thread Richard Stockton
> On Aug. 26, 2012, 7:44 a.m., Greg T wrote: > > Review: This doesn't really fix 297842, or does it? If I understand the > > reporter correctly, he wants to move with Up/Down keys in the search view > > as soon as he enters a search query. With your patch applied I still have > > to hit the ta

Re: Review Request: Kickoff-Widget: Add Key_Tab support for navigation from search Bar (4.8)

2012-08-26 Thread Richard Stockton
> On Aug. 26, 2012, 7:50 a.m., Greg T wrote: > > besides the points mentioned in review 106125, you have to remember that > > KDE 4.8 is already EOL and there will be no more bugfix release (i.e. > > 4.8.6). Yes, but I was asked to put it on the 4.8 tree in case a packager wants to pick it up

Re: Review Request: Usability: Add keyboard navigation to Kickoff GUI (within and among all Views)

2012-08-26 Thread Richard Stockton
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106125/ --- (Updated Aug. 26, 2012, 3:52 p.m.) Review request for Plasma, Ivan Čukić a

Re: Review Request: Kickoff-Widget: Add Key_Tab support for navigation from search Bar (4.8)

2012-08-26 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106123/#review18015 --- besides the points mentioned in review 106125, you have to reme

Re: Review Request: Usability: Add keyboard navigation to Kickoff GUI (within and among all Views)

2012-08-26 Thread Greg T
> On Aug. 23, 2012, 2:53 p.m., Greg T wrote: > > I think this time we can get kickoff-qml into kde 4.10. But this is no > > reason to push this fix not into master :) > > Richard Stockton wrote: > Thanks, Greg! I think we both plan this method for managing the two > modules, please advise

Re: Review Request: Usability: Add keyboard navigation to Kickoff GUI (within and among all Views)

2012-08-26 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106125/#review18014 --- Review: This doesn't really fix 297842, or does it? If I unders