Re: Review Request: Plasmate: Add QML Aurorae decoration support to the startpage

2012-08-13 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105773/#review17336 --- the template won't work. It's from the KCM to render an Aurorae

Re: Review Request: Plasmate: Add QML Aurorae decoration support to the startpage

2012-08-13 Thread Martin Gräßlin
> On July 28, 2012, 4:57 p.m., Antonis Tsiapaliokas wrote: > > startpage.cpp, line 148 > > > > > > Should we change it to "Window Decoration"? yeah that would be a good idea. > On July 28, 2012, 4:57 p.m., Antoni

Re: Review Request: Adding notify signals to FrameSvgItem

2012-08-13 Thread Daker Pinheiro
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105987/#review17326 --- Ship it! I just would put the emit after the call to update()

move plasma tools to plasmate

2012-08-13 Thread Giorgos Tsiapaliokas
Hello, my GSoC tasks included to move the plasma tools(those are kde-workspace/plasma/generic/tools) into plasmate. In order to do that I will use the "git subtree" command. With git subtree I will make a copy of kde-workspace/plasma/generic/tools into plasmate and then I will remove with git rm

Re: Review Request: Dolphin reports open locations to the activity manager

2012-08-13 Thread Ivan Čukić
> On Aug. 12, 2012, 9:05 p.m., Frank Reininghaus wrote: > > Thanks for the patch! > > > > I'd say that it looks good code-wise (can't say much about the CMake stuff > > though, my CMake knowledge is rather limited). > > > > However, I don't think that we should keep track of the locations that

Translations

2012-08-13 Thread Dmitry
Hello! If current C++ system tray applet doesn't run then QML system tray will have configuration dialog with untranslated string. Do you know why it may occur? Thank you! ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailm

Re: Review Request: Dolphin reports open locations to the activity manager

2012-08-13 Thread Ivan Čukić
> On Aug. 12, 2012, 9:05 p.m., Frank Reininghaus wrote: > > Thanks for the patch! > > > > I'd say that it looks good code-wise (can't say much about the CMake stuff > > though, my CMake knowledge is rather limited). > > > > However, I don't think that we should keep track of the locations that