Re: Review Request: better handling of Removable property for volumes in soliddevice engine

2012-07-06 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105432/#review15490 --- Just my 2 cents: This piece of API does not seem to belong t

Re: Patch to fix order of includes in kactivities (for FreeBSD)

2012-07-06 Thread Ivan Čukić
On 07/07/12 02:24, Alberto Villa wrote: I have a KDE commit bit, so I can commit it. You have the permission to push. Are you going to parch the master as well (the file is now in src/service/ directory) or should I? Cheers, Ivan ___ Plasma-devel mai

[KDE Bugtracking System] REMINDER: current Plasma regressions

2012-07-06 Thread bugzilla_noreply
Please find below a list of the current regressions reported for Plasma This search was scheduled by myr...@kde.org. Plasma regressions -- Bug 291676: https://bugs.kde.org/show_bug.cgi?id=291676 Priority: NOR Severity: normal Platform: Gentoo Packages Assignee: plasma-b

Patch to fix order of includes in kactivities (for FreeBSD)

2012-07-06 Thread Alberto Villa
Hello! I'd like someone to approve the attached patch which fixes the order of include directories in kactivities/services. It is required on FreeBSD to be able to build kactivities port when KDE-Libs 3 is installed (we install KDE SC 4 to non-default prefix, so if Soprano include directory is inc

Re: Review Request: fixed widget explorer or activity manager not closed when clicking desktop area above panel

2012-07-06 Thread Gregor Tätzner
Ya, thats right. Review the patch. The widget explorer won't close if you click on desktop. On Friday 06 July 2012 11:22:16 Xavier Sythe wrote: > Isn't this by design? Users would be dragging widgets to place on their > desktop; the widget explorer shouldn't close on them during that process. >

Re: Review Request: fixed widget explorer or activity manager not closed when clicking desktop area above panel

2012-07-06 Thread Xavier Sythe
Isn't this by design? Users would be dragging widgets to place on their desktop; the widget explorer shouldn't close on them during that process. (i.e., they click on the background after dragging a widget onto it) This would require users to specifically avoid clicking on the desktop area, and th

Re: Review Request: Fix position of widget explorer tooltip

2012-07-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105447/#review15454 --- This review has been submitted with commit 0df8824c65225b9475c