Re: Review Request: better handling of Removable property for volumes in soliddevice engine

2012-07-04 Thread Andriy Gapon
> On July 4, 2012, 10:19 p.m., Alex Fiestas wrote: > > The patch may make sense but, what does it fix exactly? Detection of my USB stick when used with FreeBSD as removable media. - Andriy --- This is an automatically generated e-mail.

Re: Review Request: better handling of Removable property for volumes in soliddevice engine

2012-07-04 Thread Andriy Gapon
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105432/ --- (Updated July 5, 2012, 6:44 a.m.) Review request for Plasma and Solid. C

[KDE Bugtracking System] REMINDER: current Plasma regressions

2012-07-04 Thread bugzilla_noreply
Please find below a list of the current regressions reported for Plasma This search was scheduled by myr...@kde.org. Plasma regressions -- Bug 291676: https://bugs.kde.org/show_bug.cgi?id=291676 Priority: NOR Severity: normal Platform: Gentoo Packages Assignee: plasma-b

Re: Review Request: better handling of Removable property for volumes in soliddevice engine

2012-07-04 Thread Alex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105432/#review15388 --- The patch may make sense but, what does it fix exactly? - Alex

Adding an image to slideshow.

2012-07-04 Thread Varun Herale
> > > i think that would be a highly unexpected for the user as image files > would end > up copied seemingly randomly all over the place. no .. what needs to > happen is > that the wallpaper plugin needs to be fixed so that it remembers the added > path > correctly. > (classic example of "fix, don

Re: Review Request: better handling of Removable property for volumes in soliddevice engine

2012-07-04 Thread Andriy Gapon
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105432/ --- (Updated July 4, 2012, 8:28 a.m.) Review request for Plasma and Solid. D

Review Request: better handling of Removable property for volumes in soliddevice engine

2012-07-04 Thread Andriy Gapon
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105432/ --- Review request for Plasma and Solid. Description --- Currently the co

Re: Review Request: kickoff: save recent applications list on every change to it

2012-07-04 Thread Andriy Gapon
> On May 31, 2012, 10:09 a.m., Aaron J. Seigo wrote: > > the real fubar here is that it stores this information internally in its > > own config file. this really ought to be stored/retrieved from nepomuk > > and/or zeitgeist. > > > > i've cc'd Trever on this because he may have something to s

Re: Review Request: kickoff: save recent applications list on every change to it

2012-07-04 Thread Andriy Gapon
> On May 31, 2012, 10:09 a.m., Aaron J. Seigo wrote: > > plasma/desktop/applets/kickoff/core/recentapplications.cpp, line 42 > > > > > > holding on to groups like this is a bit dangerous; you need to be able > > to

Re: Review Request: use window role to detect the dashboard

2012-07-04 Thread Andreas Demmer
> On July 4, 2012, 7:57 a.m., Andreas Demmer wrote: > > Ship It! I missed that windowRole would be a much better distinction than windowClass is when I initially implemented this effect. Your patch definitely makes sense, so ship it! - Andreas --

Re: Review Request: use window role to detect the dashboard

2012-07-04 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/#review15360 --- Ship it! from my side ok, maybe wait a day whether a plasma de

Re: Review Request: use window role to detect the dashboard

2012-07-04 Thread Andreas Demmer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/#review15359 --- Ship it! Ship It! - Andreas Demmer On June 28, 2012, 7:42 p

Re: Review Request: kickoff: save recent applications list on every change to it

2012-07-04 Thread Andriy Gapon
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105112/ --- (Updated July 4, 2012, 7:57 a.m.) Review request for Plasma and Trever Fis