Re: Review Request: Plasmate: Add Tabbox support to the startpage

2012-05-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105011/#review14107 --- startpage.cpp

Re: Review Request: Plasmate: fix publisher's combobox and doCMake slot

2012-05-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104969/#review14103 --- publisher/publisher.cpp

Re: Review Request: Plasmate: fix publisher's combobox and doCMake slot

2012-05-23 Thread Sebastian Kügler
> On May 22, 2012, 12:49 p.m., Aaron J. Seigo wrote: > > publisher/publisher.cpp, line 132 > > > > > > looks like a stray change... (though signign could be fixed to signing > > ;) > > Giorgos Tsiapaliwkas wrote:

Re: Review Request: Plasmate: fix publisher's combobox and doCMake slot

2012-05-23 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104969/#review14091 --- A side note here. Why publisher doesn't use a *.ui file? I gue

Re: Review Request: Plasmate: fix publisher's combobox and doCMake slot

2012-05-23 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104969/ --- (Updated May 23, 2012, 6:25 p.m.) Review request for Plasma. Changes ---

Re: Review Request: Plasmate: fix publisher's combobox and doCMake slot

2012-05-23 Thread Giorgos Tsiapaliwkas
> On May 22, 2012, 11:22 p.m., Sebastian Kügler wrote: > > Looks like a sensible change, otherwise. If you've fixed the issues aseigo > > notes, please go ahead and merge into master. > > > > In the same part, there's an interaction problem, however: > > Assumption: installing an app is quite a

Re: Review Request: Plasmate: fix publisher's combobox and doCMake slot

2012-05-23 Thread Giorgos Tsiapaliwkas
> On May 22, 2012, 12:49 p.m., Aaron J. Seigo wrote: > > publisher/publisher.cpp, line 132 > > > > > > looks like a stray change... (though signign could be fixed to signing > > ;) signing doesn't work? I have to

Re: Review Request: Backport 'Fixed Lancelot build when pimlibs are not present'

2012-05-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104875/#review14088 --- This review has been submitted with commit e6d57b0164a95ff6663

Re: HIG standards (from KDE-Frameworks)

2012-05-23 Thread Aurélien Gâteau
Le mardi 22 mai 2012 19:50:01 Djuro Drljaca a écrit : > > I personally prefer ctrl + page up|down as I find them more symetrict and > > intuitive, but I may be the minority here. > > > > Aurélien > > ___ > > Plasma-devel mailing list > > Plasma-devel@kd

Re: Review Request: Plasmate: Add Tabbox support to the startpage

2012-05-23 Thread Sebastian Kügler
On Wednesday, May 23, 2012 05:20:25 Antonis Tsiapaliokas wrote: > 2)Some lines doesn't have any differences > because i have remove some whitespaces and "tabs"... In the future, please put them in a separate patch, that makes reviewing a lot easier. > 1)The icons for the tabbox are wrong. I have