Re: Review Request: Save scrollbar position on plasma exit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104258/ --- (Updated March 13, 2012, 6:44 p.m.) Review request for Plasma, Aaron J. Se

Re: Review Request: Save scrollbar position on plasma exit

> On March 13, 2012, 1:12 p.m., Marco Martin wrote: > > looks good, a thing i would like to be tested is when the saved position is > > invalid, like either negative or an enormous value. > > > > this shouldn't break it (is even quite probable a value not being valid > > anymore because there

Re: Review Request: Save scrollbar position on plasma exit

> On March 13, 2012, 1:12 p.m., Marco Martin wrote: > > looks good, a thing i would like to be tested is when the saved position is > > invalid, like either negative or an enormous value. > > > > this shouldn't break it (is even quite probable a value not being valid > > anymore because there

Re: Review Request: Save scrollbar position on plasma exit

> On March 13, 2012, 1:12 p.m., Marco Martin wrote: > > looks good, a thing i would like to be tested is when the saved position is > > invalid, like either negative or an enormous value. > > > > this shouldn't break it (is even quite probable a value not being valid > > anymore because there

Re: Review Request: Save scrollbar position on plasma exit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104258/ --- (Updated March 13, 2012, 1:51 p.m.) Review request for Plasma, Aaron J. Se

Re: Review Request: Save scrollbar position on plasma exit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104258/#review11354 --- looks good, a thing i would like to be tested is when the saved

Re: Review Request: Save scrollbar position on plasma exit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104258/ --- (Updated March 13, 2012, 1:06 p.m.) Review request for Plasma, Aaron J. Se

Re: Review Request: Merge the final and fixed QML battery monitor to master.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 13, 2012, 11:59 a.m.) Review request for Plasma. Changes

Review Request: Save scrollbar position on plasma exit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104258/ --- Review request for Plasma, Aaron J. Seigo, Marco Martin, and Fredrik Höglund

Re: Review Request: Merge the final and fixed QML battery monitor to master.

> On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote: > > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 66 > > > > > > The word puzzle here is not translatable. You'll need to enclose a f

Re: Review Request: Merge the final and fixed QML battery monitor to master.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 13, 2012, 11:14 a.m.) Review request for Plasma. Changes

Re: Review Request: Merge the final and fixed QML battery monitor to master.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 13, 2012, 10:26 a.m.) Review request for Plasma. Changes

Re: Review Request: Merge the final and fixed QML battery monitor to master.

> On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote: > > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 81 > > > > > > This should not be in there, basically only if it has been enabled b

Re: Review Request: Merge the final and fixed QML battery monitor to master.

Hi Viranch, On Tuesday, March 13, 2012 09:52:27 Viranch Mehta wrote: > > On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote: > > > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line > > > 81 > > > >

Re: Review Request: Merge the final and fixed QML battery monitor to master.

> On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote: > > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 81 > > > > > > This should not be in there, basically only if it has been enabled b

Re: Review Request: Merge the final and fixed QML battery monitor to master.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 13, 2012, 9:51 a.m.) Review request for Plasma. Changes -

Re: Workflow Idea for 4.10

Ben Cooksley wrote: > On Tue, Mar 13, 2012 at 7:58 PM, Ignat Semenov > wrote: >> Hello fellow KDE devs! >> >> While I'm not an experienced developer nor manager, the planned >> transition to gerrit really troubles me. In particular, I have the >> following questions: >> >> 1)The gerrit installati

Re: Workflow Idea for 4.10

On Tue, Mar 13, 2012 at 7:58 PM, Ignat Semenov wrote: > Hello fellow KDE devs! > > While I'm not an experienced developer nor manager, the planned transition > to gerrit really troubles me. In particular, I have the following questions: > > 1)The gerrit installation used in qt makes it impossible