Re: Review Request: plasmoid folderview - context menu empty trash bin

2011-11-28 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103282/#review8570 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 28, 2011, 3:52 p.

Review Request: plasmoid folderview - context menu empty trash bin

2011-11-28 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103282/ --- Review request for Plasma. Description --- I incorporated the proposa

Re: Review Request: Plasmate:now StartPage::createNewProject() creates the plasmateprojectrc and not the StartPage::loadLocalProject()

2011-11-28 Thread Aaron J. Seigo
> On Nov. 28, 2011, 3:46 p.m., Aaron J. Seigo wrote: > > now that's a nice simplification :) one other note: please be sure that all the rest of the plasmate code that assumes this directory structure (if any) is modified to work properly with this new approach. - Aaron J.

Re: Review Request: Plasmate:now StartPage::createNewProject() creates the plasmateprojectrc and not the StartPage::loadLocalProject()

2011-11-28 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102732/#review8567 --- Ship it! now that's a nice simplification :) - Aaron J. Seigo

Re: Review Request: Plasmate:now StartPage::createNewProject() creates the plasmateprojectrc and not the StartPage::loadLocalProject()

2011-11-28 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102732/ --- (Updated Nov. 28, 2011, 2:52 p.m.) Review request for Plasma. Changes --

Re: Review Request: Plasmate:now StartPage::createNewProject() creates the plasmateprojectrc and not the StartPage::loadLocalProject()

2011-11-28 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102732/ --- (Updated Nov. 28, 2011, 2:48 p.m.) Review request for Plasma. Descriptio

Re: Review Request: Plasmate:images can now be added to projects

2011-11-28 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102290/ --- (Updated Nov. 28, 2011, 1:50 p.m.) Review request for Plasma and Aaron J.

Re: Review Request: Plasmate: Add mimetype support into the "executable scripts"

2011-11-28 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102357/#review8565 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 28, 2011, 9:29 a.

Re: Create new bugzilla components for the dataengines??

2011-11-28 Thread Aaron J. Seigo
On Monday, November 28, 2011 10:58:35 Giorgos Tsiapaliwkas wrote: > do you believe that some new bugzilla components for the dataengines > that could be helpful? done ... -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core develo

Re: Create new bugzilla components for the dataengines??

2011-11-28 Thread Giorgos Tsiapaliwkas
On 28 November 2011 12:44, Marco Martin wrote: > sure, but when we are triaging them if we have a category where we can move > it, there are less chance to forget about them. This is a very good reason for creating those bug components. These days we don't have manpower or the will,in order to k

Re: Create new bugzilla components for the dataengines??

2011-11-28 Thread asraniel
It would be easy to create those components, i can do that. The important part is to have maintainers of those new components. Currently 80%+ of the plasma components have no maintainer. Triaging bugs into the right component only makes limited sense, since they get looked at at random anyway.

Re: Create new bugzilla components for the dataengines??

2011-11-28 Thread Marco Martin
On Monday 28 November 2011, todd rme wrote: > > Also for some plasmoids that use the same dataengine it would be > > "nicer" to have the bugs of the dataengines seperate. > > > > Cons > > Someone has to do it. > > > > What do you think?+1 -1 > > I doubt most users would be able to tell whether a

Re: Create new bugzilla components for the dataengines??

2011-11-28 Thread Gregor Tätzner
Am Montag, 28. November 2011, 11:04:17 schrieb todd rme: > On Mon, Nov 28, 2011 at 9:58 AM, Giorgos Tsiapaliwkas > > wrote: > > Hello, > > > > do you believe that some new bugzilla components for the dataengines > > that could be helpful? > > In order to split the bugs of the dataengines from th

Re: Create new bugzilla components for the dataengines??

2011-11-28 Thread todd rme
On Mon, Nov 28, 2011 at 9:58 AM, Giorgos Tsiapaliwkas wrote: > Hello, > > do you believe that some new bugzilla components for the dataengines > that could be helpful? > In order to split the bugs of the dataengines from the bugs of the plasmoids. > > A few pros and cons that i could think of. > >

Re: Review Request: single shot deleteLater needed in DataEngine::removeSource()

2011-11-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103247/#review8561 --- This review has been submitted with commit a4a4679d0e82d88392c2

Re: Review Request: Plasmate: Add mimetype support into the "executable scripts"

2011-11-28 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102357/ --- (Updated Nov. 28, 2011, 9:29 a.m.) Review request for Plasma. Changes --

Re: Review Request: Plasmate: Add mimetype support into the "executable scripts"

2011-11-28 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102357/#review8560 --- Ship it! minor issue left, but it's essentially ready to go ...

Create new bugzilla components for the dataengines??

2011-11-28 Thread Giorgos Tsiapaliwkas
Hello, do you believe that some new bugzilla components for the dataengines that could be helpful? In order to split the bugs of the dataengines from the bugs of the plasmoids. A few pros and cons that i could think of. Pros It would be easier for the contributors to track down the issue. The da

Re: Review Request: Plasmate: Add mimetype support into the "executable scripts"

2011-11-28 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102357/ --- (Updated Nov. 28, 2011, 8:53 a.m.) Review request for Plasma. Changes --

Re: Review Request: Fix build of Plasma Marble Globe Wallpaper following API changes in Marble

2011-11-28 Thread Bernhard Beschow
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103243/#review8484 --- Ship it! The patch looks good. Thanks for pointing this out and