Re: Review Request: Add fromTheme property to QIconItem in QtExtraComponents for theme icons in QML

2011-10-31 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103009/ --- (Updated Oct. 31, 2011, 9:27 p.m.) Review request for KDE Runtime and Plas

Re: IconTasks taskmanager changes

2011-10-31 Thread Craig Drummond
On 27/10/11 15:29, Aaron J. Seigo wrote: On Thursday, October 27, 2011 14:24:26 Craig Drummond wrote: 1. TaskAction changes - these are self contained anyway. 2. Launcher matching - mainly TaskItem::launcherUrl() changes. 3. Launcher ordering - basically everything else. Would that be enough?

Re: PlasmaComponents.Button missing feature: use system icons!

2011-10-31 Thread Mark
On Mon, Oct 31, 2011 at 4:57 PM, Aaron J. Seigo wrote: > On Monday, October 31, 2011 16:31:57 Mark wrote: > > On Mon, Oct 31, 2011 at 4:10 PM, Aaron J. Seigo wrote: > > > On Monday, October 31, 2011 15:26:07 Marco Martin wrote: > > > > QIcon::fromTheme (still doesn't do caching compared to kicon

Re: QML device notifier

2011-10-31 Thread Viranch Mehta
On Sun, Oct 30, 2011 at 10:03 PM, Marco Martin wrote: > the system kcms is the only detail still missing :p > after this is in, i'll merge > > it's in! commit: http://commits.kde.org/kdelibs/f53ef3872b3755350ca5eb99eea8ef3b96dd8c74 pushed to kdelibs KDE/4.7 branch > -- > Marco Martin >

Re: PlasmaComponents.Button missing feature: use system icons!

2011-10-31 Thread Aaron J. Seigo
On Monday, October 31, 2011 16:31:57 Mark wrote: > On Mon, Oct 31, 2011 at 4:10 PM, Aaron J. Seigo wrote: > > On Monday, October 31, 2011 15:26:07 Marco Martin wrote: > > > QIcon::fromTheme (still doesn't do caching compared to kiconloader > > > iirc?) > > > > not yet, no. > > > > > and the api

Re: PlasmaComponents.Button missing feature: use system icons!

2011-10-31 Thread Mark
On Mon, Oct 31, 2011 at 4:10 PM, Aaron J. Seigo wrote: > On Monday, October 31, 2011 15:26:07 Marco Martin wrote: > > QIcon::fromTheme (still doesn't do caching compared to kiconloader iirc?) > > not yet, no. > > > and the api in qml won't change at all > > as long as "kde" doesn't appear in the

Re: PlasmaComponents.Button missing feature: use system icons!

2011-10-31 Thread Aaron J. Seigo
On Monday, October 31, 2011 15:26:07 Marco Martin wrote: > QIcon::fromTheme (still doesn't do caching compared to kiconloader iirc?) not yet, no. > and the api in qml won't change at all as long as "kde" doesn't appear in the paths, is all :) -- Aaron J. Seigo humru othro a kohnu se GPG Finge

Re: PlasmaComponents.Button missing feature: use system icons!

2011-10-31 Thread Marco Martin
On Monday 31 October 2011, Daker Fernandes Pinheiro wrote: > I think we should have a declarative image provider for getting icons. In > this way we should just do something like: > > Button { >icon: "image://kde/desiredIcon" > } > > What do you think? > > Cheers, > yeah, i would like to p

Re: PlasmaComponents.Button missing feature: use system icons!

2011-10-31 Thread Marco Martin
On Monday 31 October 2011, Aaron J. Seigo wrote: > On Monday, October 31, 2011 09:57:26 Daker Fernandes Pinheiro wrote: > > I think we should have a declarative image provider for getting icons. In > > this way we should just do something like: > > > > Button { > > > >icon: "image://kde/desir

Re: PlasmaComponents.Button missing feature: use system icons!

2011-10-31 Thread Aaron J. Seigo
On Monday, October 31, 2011 09:57:26 Daker Fernandes Pinheiro wrote: > I think we should have a declarative image provider for getting icons. In > this way we should just do something like: > > Button { >icon: "image://kde/desiredIcon" > } > > What do you think? given that we have QIcon::fro

Re: PlasmaComponents.Button missing feature: use system icons!

2011-10-31 Thread Daker Fernandes Pinheiro
I think we should have a declarative image provider for getting icons. In this way we should just do something like: Button { icon: "image://kde/desiredIcon" } What do you think? Cheers, On Monday, October 31, 2011 07:27:14 AM Marco Martin wrote: > On Monday 31 October 2011, Aaron J. Seigo

Re: PlasmaComponents.Button missing feature: use system icons!

2011-10-31 Thread Marco Martin
On Monday 31 October 2011, Aaron J. Seigo wrote: > On Monday, October 31, 2011 10:12:57 Marco Martin wrote: > > when is not an applet (ie just qmlviewer, or qml packages), a package may > > or may not be there > > this is one of the things i really, really liked about how Packages are > implemente

Re: PlasmaComponents.Button missing feature: use system icons!

2011-10-31 Thread Aaron J. Seigo
On Monday, October 31, 2011 10:12:57 Marco Martin wrote: > when is not an applet (ie just qmlviewer, or qml packages), a package may or > may not be there this is one of the things i really, really liked about how Packages are implemented in the Javascript API. anything can register a Package at

Re: Review Request: picture frame widget - move to next picture on delete

2011-10-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103001/#review7772 --- This review has been submitted with commit 2d948694b262444fd938

Re: Review Request: picture frame widget - move to next picture on delete

2011-10-31 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103001/#review7771 --- personally, what i'd do in SlideShow::pictureLoaded is this: if

Re: PlasmaComponents.Button missing feature: use system icons!

2011-10-31 Thread Mark
On Mon, Oct 31, 2011 at 10:02 AM, Marco Martin wrote: > On Sunday 30 October 2011, Mark wrote: > > Hi, > > > > I'm curently using PlasmaComponents.Button but it seems to miss a quite > > important feature. I can't use system icons! > > Icon paths can be set though... > > > > I wouldn't mind imple

Re: PlasmaComponents.Button missing feature: use system icons!

2011-10-31 Thread Marco Martin
On Monday 31 October 2011, Aaron J. Seigo wrote: > On Sunday, October 30, 2011 23:47:32 Mark wrote: > > I'm kinda fearing that functionality is not even existing yet (in core?). > > If it isn't then i will implement that as well, but a pointer to the > > plasma > > This is likely something that ne

Re: PlasmaComponents.Button missing feature: use system icons!

2011-10-31 Thread Marco Martin
On Sunday 30 October 2011, Mark wrote: > Hi, > > I'm curently using PlasmaComponents.Button but it seems to miss a quite > important feature. I can't use system icons! > Icon paths can be set though... > > I wouldn't mind implementing this if it it's oke with you all. Just one > question: How can

Re: PlasmaComponents.Button missing feature: use system icons!

2011-10-31 Thread Aaron J. Seigo
On Sunday, October 30, 2011 23:47:32 Mark wrote: > I'm kinda fearing that functionality is not even existing yet (in core?). > If it isn't then i will implement that as well, but a pointer to the plasma This is likely something that needs to be bound in from C++. Reason is that it should also be