Re: IconTasks taskmanager changes

2011-10-28 Thread Jan Gerrit José Marker
On Thursday 27 October 2011 14:10:50 Craig Drummond wrote: [snip] > No, just to now allow it. And for the user to be prompted to locate the > launcher. > > > I cant imagine many people pinning kcm's. > > > > yes, it's an edge case for certain. would be nice if it works, all the > > same. > > But,

Re: Some help for recreating the Plasma Tool Box in QML

2011-10-28 Thread Mark
On Thu, Oct 27, 2011 at 2:24 PM, Aaron J. Seigo wrote: > On Thursday, October 27, 2011 14:05:42 Mark wrote: > > Ah men i hate this.. This is a typical "it's right under your nose" case > :p > > usually only after it's been pointed out is it right under your now; before > that it may as well be ve

Re: Review Request: picture frame widget - open potd picture

2011-10-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102817/#review7725 --- This review has been submitted with commit c0360bc3ba5e6b049a66

Re: Review Request: picture frame widget - open potd picture

2011-10-28 Thread Aaron J. Seigo
> On Oct. 28, 2011, 11:05 a.m., Aaron J. Seigo wrote: > > Ship It! > > Greg T wrote: > cool, but I have no write access...your turn ;) a few more patches like this one and i'll make sure you have write access ;) seriously though: if you wish to continue contributing over the longer term (

Re: Review Request: picture frame widget - open potd picture

2011-10-28 Thread Greg T
> On Oct. 25, 2011, 11:35 a.m., Aaron J. Seigo wrote: > > applets/frame/slideshow.cpp, lines 221-222 > > > > > > much cleaner than this, which introduces an assumption on where potd > > stores things into the widge

Re: Review Request: picture frame widget - open potd picture

2011-10-28 Thread Greg T
> On Oct. 28, 2011, 11:05 a.m., Aaron J. Seigo wrote: > > Ship It! cool, but I have no write access...your turn ;) - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102817/#review771

Re: Review Request: picture frame widget - open potd picture

2011-10-28 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102817/#review7711 --- Ship it! Ship It! - Aaron J. Seigo On Oct. 28, 2011, 10:20 a

Re: Review Request: picture frame widget - open potd picture

2011-10-28 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102817/ --- (Updated Oct. 28, 2011, 10:20 a.m.) Review request for Plasma. Changes -

Re: IconTasks taskmanager changes

2011-10-28 Thread Martin Klapetek
On Fri, Oct 28, 2011 at 09:47, Craig Drummond wrote: > > > > > it cannot be run two times. The check for an already running Amarok > > should > > > > happen just in Amarok itself... > > > > And here with the unpatched libtaskmanager and the standard > > task-widget > > > > exactly what you propose

Re: IconTasks taskmanager changes

2011-10-28 Thread Aaron J. Seigo
On Friday, October 28, 2011 09:47:50 Craig Drummond wrote: > The problem here is that the taskmanager library does not really manage > tasks, but windows. So, when Quassel is minimised to the system try, the > taskamanger emits a windowRemoved - and the task applets remove the entry. > The launcher

Re: IconTasks taskmanager changes

2011-10-28 Thread Craig Drummond
> > > it cannot be run two times. The check for an already running Amarok > should > > > happen just in Amarok itself... > > > And here with the unpatched libtaskmanager and the standard > task-widget > > > exactly what you propose happens. > > > > Ok, bad example. Think of any non-KUniqueApp in

Re: IconTasks taskmanager changes

2011-10-28 Thread Craig Drummond
Original-Nachricht > Datum: Fri, 28 Oct 2011 00:35:46 +0100 > Von: David Edmundson > An: plasma-devel@kde.org > Betreff: Re: IconTasks taskmanager changes > In KDE Telepathy we have several dbus-activated apps that > 1) Do not have .desktop files > 2) Should not be able to be p