Review Request: kde-runtime:fix the coding style of plasmacomponents

2011-09-23 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102684/ --- Review request for Plasma. Summary --- Hello, at kde-runtime/plasma/

Re: Review Request: Plasmate:add a destructor and some changes to the destructor of mainwindow.ccp

2011-09-23 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101916/ --- (Updated Sept. 23, 2011, 4:20 p.m.) Review request for Plasma. Changes -

Re: major overhauls in plasma declarative for dataengines

2011-09-23 Thread Marco Martin
On Friday 23 September 2011, Aaron J. Seigo wrote: > On Friday, September 23, 2011 13:31:59 Marco Martin wrote: > > > (Marco: i ended up putting the source filter back in), > > > > reason? ;) > > it's used in SLC and given that i don't have #s for how light DataSource > is, and how many lines it

Re: QToolTip of Ksnapshot disables the plasma-effects.

2011-09-23 Thread Aaron J. Seigo
On Friday, September 23, 2011 15:24:09 jignesh kakadiya wrote: > I am fixing https://bugs.kde.org/show_bug.cgi?id=235545 . cool :) > Can any one suggest me how to modify the QToolTip positon such that it will > display in the center of the screen displaying it in the center of the screen is prob

Re: major overhauls in plasma declarative for dataengines

2011-09-23 Thread Aaron J. Seigo
On Friday, September 23, 2011 13:31:59 Marco Martin wrote: > > (Marco: i ended up putting the source filter back in), > > reason? ;) it's used in SLC and given that i don't have #s for how light DataSource is, and how many lines it added to the QML, i looked if it was possible to re-add it in a

Re: Review Request: do not split the year in the clock tip

2011-09-23 Thread Aaron J. Seigo
> On Sept. 23, 2011, 11:37 a.m., Commit Hook wrote: > > This review has been submitted with commit > > 1f068490c0b431ff05f1965c91e5d06d7ae3b7f6 by Aaron Seigo to branch master. the patch i committed is significantly different than the one in this review, but the committed patch was motivated/i

Re: Review Request: do not split the year in the clock tip

2011-09-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102621/#review6762 --- This review has been submitted with commit 1f068490c0b431ff05f1

Re: major overhauls in plasma declarative for dataengines

2011-09-23 Thread Marco Martin
On Friday 23 September 2011, Aaron J. Seigo wrote: > hi all... > > last night i committed to master in kde-runtime some major changes to the > code that handles the briding of Plasma::DataEngine into QML. there was > some complexity in there that was unnecessary and some performance > improvements

QToolTip of Ksnapshot disables the plasma-effects.

2011-09-23 Thread jignesh kakadiya
Hi, I am fixing https://bugs.kde.org/show_bug.cgi?id=235545 . I have modified the simple looking effect to blinking effect (which toggles the color every after one second interval http://paste.kde.org/126403/) in palette which is shown in the corner. Can any one suggest me how to modify the QToo

major overhauls in plasma declarative for dataengines

2011-09-23 Thread Aaron J. Seigo
hi all... last night i committed to master in kde-runtime some major changes to the code that handles the briding of Plasma::DataEngine into QML. there was some complexity in there that was unnecessary and some performance improvements to be found as well. there is still an issue with performa