QML X-Plasma-DefaultSize purpose

2011-08-21 Thread Shaun Reich
What is the purpose of X-Plasma-DefaultSize in a qml applet? One might think it is the default size of the applet, maybe it is the root item of mine which is overriding it, but I don't see this being followed. In fact, if I set it to 10,10, the only *visible* change which occurs is the fact that t

Re: Review Request: Bugfix: Plasma::PackageMetadata::read: Match the behavior of KService

2011-08-21 Thread Kevin Kofler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102404/ --- (Updated Aug. 22, 2011, 12:49 a.m.) Review request for Plasma. Changes -

Review Request: Bugfix: Plasma::PackageMetadata::read: Match the behavior of KService

2011-08-21 Thread Kevin Kofler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102404/ --- Review request for Plasma. Summary --- This one is a bugfix, and so s

Re: Review Request: Implement automatic scanning of source code for required data engines

2011-08-21 Thread Kevin Kofler
> On Aug. 21, 2011, 1:31 p.m., Marco Martin wrote: > > to me seems quite good. other opinions? > > > > the only problem as usual is that kdelibs master is frozen, so this should > > go in the frameworks branch > > Kevin Kofler wrote: > The problem is that, as far as Fedora is concerned, we

Re: Review Request: Implement automatic scanning of source code for required data engines

2011-08-21 Thread Kevin Kofler
> On Aug. 21, 2011, 1:31 p.m., Marco Martin wrote: > > to me seems quite good. other opinions? > > > > the only problem as usual is that kdelibs master is frozen, so this should > > go in the frameworks branch The problem is that, as far as Fedora is concerned, we really need this (and the pr

Re: Review Request: Implement automatic scanning of source code for required data engines

2011-08-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102350/#review5880 --- to me seems quite good. other opinions? the only problem as usu