Re: Review Request: plasma-windowed: Quit on closeEvent not on hideEvent

2011-06-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101802/#review4257 --- This review has been submitted with commit 3c51bdc87e1a05560b3a

Re: Review Request: plasma-windowed: Quit on closeEvent not on hideEvent

2011-06-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101802/#review4255 --- Ship it! looks good; this should go into the 4.7 branch and mas

Re: Review Request: Use underscore instead of hyphen in .so name

2011-06-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101801/#review4254 --- yes, it's unfortunately inconsistent. however, is there any part