Re: Review Request: Fixing massive memory consumption in KWin using the raster graphicssystem.

2011-06-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101385/#review4204 --- This review has been submitted with commit d8949d77b5bc33d540dc

Re: Review Request: Fix bug 276082 and refactor timeline in plasmate

2011-06-27 Thread Etienne Rebetez
> On June 27, 2011, 11:51 a.m., Aaron J. Seigo wrote: > > looks good, minus the two small memory leaks; i'm not as convinced that the > > direction of the timeline is "correct" but let's keep it this way for now. > > after fixing the two memory leaks, please commit... cheers :) Yes, i am not c

Re: Review Request: Fixing massive memory consumption in KWin using the raster graphicssystem.

2011-06-27 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101385/#review4197 --- Ship it! looks good; let's try it out for 4.8 and now that mast

Re: Review Request: Fix bug 276082 and refactor timeline in plasmate

2011-06-27 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101728/#review4196 --- Ship it! looks good, minus the two small memory leaks; i'm not

Re: libplasma2: split anything

2011-06-27 Thread Aaron J. Seigo
On Sunday, June 26, 2011 19:25:08 Marco Martin wrote: > now, when we do loadApplet it would be loaded this new thing, and the trick > unfortunately is just moved on how to selectively create a qml object tree > (and eventually load a c++ plugin on a Plasmoid* subclass) OR load instead > the old plu