Re: Review Request: Changes at the functionality of the delete button.

2011-06-07 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101535/ --- (Updated June 7, 2011, 3:24 p.m.) Review request for Plasma. Changes ---

Review Request: Changes at the functionality of the delete button.

2011-06-07 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101535/ --- Review request for Plasma. Summary --- Hello, after a discussion wit

Re: Review Request: Fix possible memory and D-Bus connection leak in KStatusNotifierItem

2011-06-07 Thread Dawit Alemayehu
> On June 6, 2011, 8:38 p.m., Aaron J. Seigo wrote: > > i doubt this fix is correct. what looks more like is > > KStatusNotifierItemDBus::~KStatusNotifierItemDBus(). right now this is the > > implementation: > > > > m_dbus.unregisterService(m_service); > > > > and perhaps it should include: >