Re: Review Request: Deprecate KLineEdit::clickMessage

2011-05-13 Thread Aaron J. Seigo
> On May 14, 2011, 4:01 a.m., Shaun Reich wrote: > > Are you sure the behaviour for the Qt method 100% equivalent to the > > current? I ask this because now that the deprecated method forwards to it, > > naturally it's quite important to make sure nothing gets fscked up. > > Nicolas Alvarez wr

Re: Review Request: Deprecate KLineEdit::clickMessage

2011-05-13 Thread Nicolas Alvarez
> On May 14, 2011, 4:01 a.m., Shaun Reich wrote: > > Are you sure the behaviour for the Qt method 100% equivalent to the > > current? I ask this because now that the deprecated method forwards to it, > > naturally it's quite important to make sure nothing gets fscked up. Someone in #kde-devel

Re: Review Request: Fix build of libkdeclarative with ENABLE_FINAL.

2011-05-13 Thread Nicolas Alvarez
> On May 4, 2011, 10:05 a.m., Aaron J. Seigo wrote: > > looks fine, though i'd prefer not using underscores (something we avoid in > > the coding style :) Underscores removed, submitted in http://commits.kde.org/kdelibs/525afb748a8906518a0c913b39abe826a8673c01 (The review didn't get auto-clos

Re: Review Request: Deprecate KLineEdit::clickMessage

2011-05-13 Thread Shaun Reich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101360/#review3308 --- Are you sure the behaviour for the Qt method 100% equivalent to

Review Request: Deprecate KLineEdit::clickMessage

2011-05-13 Thread Davide Bettio
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101360/ --- Review request for kdelibs and Plasma. Summary --- Since Qt 4.7 QLine

Re: libplasma2 and QtSvg

2011-05-13 Thread Davide Bettio
Hi, On 05/13/11 15:39, Alexis Ménard wrote: > To me the solution lies in WebKit, I asked if the API was stable and > it seems that yes it's pretty good. So if we have an interest (which I > believe we do a lot), then we should make the QtSvg on top of WebKit > API happens. > > :D. What about perfo

Re: libplasma2 and QtSvg

2011-05-13 Thread Alexis Ménard
And I'll be happy to help on that respect since I'm working on WebKit every day. On Fri, May 13, 2011 at 10:39 AM, Alexis Ménard wrote: > It's Depecrated, it doesn't mean someone can't come up with a replacement. > > QtSvg is buggy, just ask Nuno and it will tell you how much he hates > that modu

Re: libplasma2 and QtSvg

2011-05-13 Thread Alexis Ménard
It's Depecrated, it doesn't mean someone can't come up with a replacement. QtSvg is buggy, just ask Nuno and it will tell you how much he hates that module. It supports only a subset of the potential of SVG spec and when I was in Nokia there was no-one to work on it, and we even broke it badly one