Re: May sprint planning

2011-05-02 Thread Kevin Ottens
On Monday 2 May 2011 20:53:44 Martin Gräßlin wrote: > On Sunday 01 May 2011 17:52:49 Aaron J. Seigo wrote: > > hi all :) > > > > the May devel sprint is starting tomorrow: > > http://contour-scrum.basyskom.org/icescrum/p/PLASMA#sprintBacklog/43 > > > > starting immediately, you can add new fe

Re: May sprint planning

2011-05-02 Thread Martin Gräßlin
On Sunday 01 May 2011 17:52:49 Aaron J. Seigo wrote: > hi all :) > > the May devel sprint is starting tomorrow: > > http://contour-scrum.basyskom.org/icescrum/p/PLASMA#sprintBacklog/43 > > starting immediately, you can add new features and stories to the Sandbox or > request existing ones

Re: Review Request: Ensure smart lists are updated on any task change in Remember The Milk plasmoid

2011-05-02 Thread Marco Martin
> On May 1, 2011, 10:25 p.m., Marco Martin wrote: > > applets/rememberthemilk/taskmodel.cpp, line 250 > > > > > > } else { > > engine->connectSource("List:" + QString::number(listId), this); > > } > > A

Re: Review Request: Ensure smart lists are updated on any task change in Remember The Milk plasmoid

2011-05-02 Thread Alexey Chernov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101182/ --- (Updated May 2, 2011, 5:51 p.m.) Review request for Plasma and Aaron J. Se

Re: Review Request: Activity ResourceInstance class for API review

2011-05-02 Thread Sebastian Trueg
> On May 2, 2011, 3:14 p.m., Ivan Čukić wrote: > > experimental/libkactivities/resourceinstance.h, line 52 > > > > > > The thing I don't like about the /empty/ constructor is that the user > > could thing the class

Re: questions about KWin shadows

2011-05-02 Thread Martin Gräßlin
On Monday 02 May 2011 15:34:52 Aaron J. Seigo wrote: > hi.. > > i just pushed a commit which attempts to replace the ShadowWindow that > PanelView in plasma-desktop was using with the _KDE_NET_WM_SHADOW hint. > > it doesn't seem to be working, however .. some general questions i have after > r

Re: Review Request: Activity ResourceInstance class for API review

2011-05-02 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101273/#review3062 --- experimental/libkactivities/resourceinstance.h

Re: Review Request: Activity ResourceInstance class for API review

2011-05-02 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101273/ --- (Updated May 2, 2011, 3:11 p.m.) Review request for Nepomuk and Plasma.

questions about KWin shadows

2011-05-02 Thread Aaron J. Seigo
hi.. i just pushed a commit which attempts to replace the ShadowWindow that PanelView in plasma-desktop was using with the _KDE_NET_WM_SHADOW hint. it doesn't seem to be working, however .. some general questions i have after reading http://community.kde.org/KWin/Shadow : * the property is a

Re: Review Request: Activity ResourceInstance class for API review

2011-05-02 Thread Ivan Čukić
> On May 2, 2011, 1:20 p.m., Aaron J. Seigo wrote: > > experimental/libkactivities/ResourceInstance.h, line 77 > > > > > > sounds like a signal rather than a method. > > > > also, is this about the URI chan

Re: Review Request: Activity ResourceInstance class for API review

2011-05-02 Thread Ivan Čukić
> On May 2, 2011, 1:03 p.m., Sebastian Trueg wrote: > > experimental/libkactivities/ResourceInstance.h, line 105 > > > > > > As mentioned on IRC I am not sure about this. How would accessing the > > new resource be

Re: Review Request: Activity ResourceInstance class for API review

2011-05-02 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101273/#review3052 --- experimental/libkactivities/ResourceInstance.h

Re: Review Request: Activity ResourceInstance class for API review

2011-05-02 Thread Ivan Čukić
> On May 2, 2011, 1:03 p.m., Sebastian Trueg wrote: > > experimental/libkactivities/ResourceInstance.h, line 77 > > > > > > How about an event enum instead of one method for each event type? > > Something like resou

Re: Review Request: Activity ResourceInstance class for API review

2011-05-02 Thread Ivan Čukić
> On May 2, 2011, 12:55 p.m., Marco Martin wrote: > > experimental/libkactivities/ResourceInstance.h, line 105 > > > > > > what about a property? has it symmetric behaviour with changeUri()? It is by default symmet

Re: Review Request: Activity ResourceInstance class for API review

2011-05-02 Thread Aaron J. Seigo
> On May 2, 2011, 1:03 p.m., Sebastian Trueg wrote: > > experimental/libkactivities/ResourceInstance.h, line 62 > > > > > > What is the mimetype required for? Some resources might not even have a > > "real" mimetype

Re: Review Request: Activity ResourceInstance class for API review

2011-05-02 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101273/ --- (Updated May 2, 2011, 1:07 p.m.) Review request for Nepomuk and Plasma.

Re: Review Request: Activity ResourceInstance class for API review

2011-05-02 Thread Ivan Čukić
> On May 2, 2011, 1:04 p.m., Ivan Čukić wrote: > > experimental/libkactivities/ResourceInstance.h, line 77 > > > > > > register, notify... ? disregard this ^^^ (should have been posted up) - Ivan ---

Re: Review Request: Activity ResourceInstance class for API review

2011-05-02 Thread Ivan Čukić
> On May 2, 2011, 12:55 p.m., Marco Martin wrote: > > experimental/libkactivities/ResourceInstance.h, line 77 > > > > > > modified sounds a bit a signal name? maybe registerModification()? register, notify... ? I do

Re: Review Request: Activity ResourceInstance class for API review

2011-05-02 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101273/#review3046 --- experimental/libkactivities/ResourceInstance.h

Re: Review Request: Activity ResourceInstance class for API review

2011-05-02 Thread Sebastian Trueg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101273/#review3043 --- experimental/libkactivities/ResourceInstance.h

Re: Review Request: Activity ResourceInstance class for API review

2011-05-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101273/#review3044 --- experimental/libkactivities/ResourceInstance.h

Review Request: Activity ResourceInstance class for API review

2011-05-02 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101273/ --- Review request for Nepomuk, Plasma, Aaron J. Seigo, Marco Martin, and Sebast

Re: Review Request: Ensure smart lists are updated on any task change in Remember The Milk plasmoid

2011-05-02 Thread Alexey Chernov
> On May 1, 2011, 10:25 p.m., Marco Martin wrote: > > generally seems correct. > > to watch out the coding style. > > it's quite a big patch, but given enough testing (and assuming this will be > > multiple commits) i think it could go in Thanks, Marco. Coding style will be fixed, thanks for co

Re: User interaction problems

2011-05-02 Thread Martin Gräßlin
On Sun, 01 May 2011 22:46:50 -0700, Ryan Rix wrote: > On Sat 30 April 2011 14:36:02 Martin Gräßlin wrote: >> - Ursprüngliche Mitteilung - >> >> > On Sat, Apr 30, 2011 at 10:23 PM, Martin Gräßlin >> >> > >> > wrote: >> > > On Saturday 30 April 2011 22:04:12 Ben Cooksley wrote: >> > > > O

Re: Review Request: Implements Plasma::TabBar::setTabHighlighted

2011-05-02 Thread Matthias Fuchs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101264/ --- (Updated May 2, 2011, 10:25 a.m.) Review request for Plasma, Aaron J. Seig