Review Request: Overrides Plasma::wallpaer method addUrls() to set Image

2011-01-20 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6391/ --- Review request for Plasma. Summary --- Method addUrls(const KUrl::List

Re: Questions about dataengines and apologizes

2011-01-20 Thread Aaron J. Seigo
On Thursday, January 20, 2011, Matthieu Gallien wrote: > I believe that some of the current solutions rely on encoding the address > in the name of a requested source. it often is, yes. > I am not sure if a service could be used and how. you could, yes, by implement serviceForSource and returnin

Questions about dataengines and apologizes

2011-01-20 Thread Matthieu Gallien
Hello dear Plasma folks, first, I would like to apologize having totally disappeared after having been the cause of memory leaks in the systray. Real life was plenty full for me at that time. I am trying to find something that is sustainable with 1h and half of time in commuter trains. This is w

Re: QML code style

2011-01-20 Thread Artur de Souza
Quoting Marco Martin : > Artur, do you know something more about coding conventions used > internally for > QML/QtComponents? if sensible we could just steal, ehm, i mean adopt them ;) In QtComponents we use the links below as a reference: http://doc.qt.nokia.com/4.7-snapshot/codingconventions

Re: QML code style

2011-01-20 Thread Ivan Čukić
> I always do the opposite, like iconImage yes, I've noticed :) The main reason I do it this way is that I easier remember the field type than name, so it narrows the completion options :) -- Cheerio, Ivan -- While you were hanging yourself on someone else's words Dying to believe in what you

Re: QML code style

2011-01-20 Thread Marco Martin
On Thursday 20 January 2011, Ivan Čukić wrote: > > qt has a (quite scarce) conventions document > > Yes, it covers a bit specific stuff where the more important things > are not present. > > The thing currently on my mind is the following - if the Qt examples > and the mentioned page are to be fo

Re: QML code style

2011-01-20 Thread Marco Martin
On Thursday 20 January 2011, Ivan Čukić wrote: > > qt has a (quite scarce) conventions document > > Yes, it covers a bit specific stuff where the more important things > are not present. > > The thing currently on my mind is the following - if the Qt examples > and the mentioned page are to be fo

Re: QML code style

2011-01-20 Thread Ivan Čukić
> qt has a (quite scarce) conventions document Yes, it covers a bit specific stuff where the more important things are not present. The thing currently on my mind is the following - if the Qt examples and the mentioned page are to be followed - we'd end up with something like this: property

Re: Review Request: Make wallpaper capable of setting particular Image

2011-01-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6375/#review9659 --- Ship it! after last revision is perfect, go for it. - Marco On

Re: Review Request: Make wallpaper capable of setting particular Image

2011-01-20 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6375/ --- (Updated Jan. 20, 2011, 7:36 p.m.) Review request for Plasma. Changes

Re: QML code style

2011-01-20 Thread Marco Martin
On Thursday 20 January 2011, Ivan Čukić wrote: > Hi all, > > I think this would be essential to decide before we dive into QML deeper. > > We're all used to kdelibs style when C++ is concerned, so our code is > generally unified all across different parts of KDE Code. QML is a new > area which no

QML code style

2011-01-20 Thread Ivan Čukić
Hi all, I think this would be essential to decide before we dive into QML deeper. We're all used to kdelibs style when C++ is concerned, so our code is generally unified all across different parts of KDE Code. QML is a new area which nobody (with the exception of Marco and a few other ppl) has ha

Re: where to download plasma-mobile solution for MeeGo?

2011-01-20 Thread Marco Martin
On Thursday 20 January 2011, Rodrigo Belém wrote: > > yes, Kubuntu is an option as well, they have an experimental ppa with > > plasma mobile, kdepim trunk with the mobile version as well, built > > against the kde 4.6 rc2 packages. > > last time I checked the plasma mobile packages were quite old

Re: where to download plasma-mobile solution for MeeGo?

2011-01-20 Thread Rodrigo Belém
On Thu, Jan 20, 2011 at 10:46 AM, Marco Martin wrote: > On Wednesday 19 January 2011, Rohan Garg wrote: >> Do meego repos even have those? Im not sure, but theres Kubuntu Mobile that > > yes, there is a personal repository made by kde ppl, that's quite ineresting > since it uses the kdelibs mobile

Re: Review Request: Make wallpaper capable of setting particular Image

2011-01-20 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6375/#review9658 --- Ship it! just needs apidox. trunk/KDE/kdelibs/plasma/wallpaper.

Re: Review Request: Make wallpaper capable of setting particular Image

2011-01-20 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6375/ --- (Updated Jan. 20, 2011, 5:44 p.m.) Review request for Plasma. Summary

Re: where to download plasma-mobile solution for MeeGo?

2011-01-20 Thread Marco Martin
On Wednesday 19 January 2011, Rohan Garg wrote: > Do meego repos even have those? Im not sure, but theres Kubuntu Mobile that yes, there is a personal repository made by kde ppl, that's quite ineresting since it uses the kdelibs mobile profile and includes koffice/calligra mobile as well. > you