Re: Review Request: The clock applet chiming per hour, half-hour and quarter hour

2010-12-12 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6108/#review9223 --- as others noted, the debug should be removed for the final patch;

Re: Review Request: The clock applet chiming per hour, half-hour and quarter hour

2010-12-12 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6108/ --- (Updated 2010-12-12 23:01:41.350300) Review request for Plasma and Anne-Mari

Re: Review Request: Use correct pixmap cache file for theme

2010-12-12 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6100/#review9220 --- i agree with the analysis of the problem: the pixmapCache object i

Re: Review Request: The clock applet chiming per hour, half-hour and quarter hour

2010-12-12 Thread John Layt
> On 2010-12-12 20:27:41, John Layt wrote: > > This is wish https://bugs.kde.org/show_bug.cgi?id=232004 > > > > I think it should be in the base clock widget, I'm sure there will be > > people wanting chimes from the standard panel clock as well, so long as > > they are off by default and don'

Re: Review Request: The clock applet chiming per hour, half-hour and quarter hour

2010-12-12 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6108/#review9215 --- This is wish https://bugs.kde.org/show_bug.cgi?id=232004 I think

Re: Compile Failure

2010-12-12 Thread John Layt
On Sunday 12 December 2010 01:53:48 Steven Sroka wrote: > I'm trying to compile kdebase and I keep getting this compile error: > /kdebase/workspace/libs/plasmaclock/calendartable.cpp:853:54: error: ‘class > KHolidays::HolidayRegionSelector’ has no member named ‘setRegionUseFlags’ > My copy of trunk

Re: Review Request: The clock applet chiming per hour, half-hour and quarter hour

2010-12-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6108/#review9213 --- could be a good idea (even if i'm not sure this should be in the d

Re: Review Request: The clock applet chiming per hour, half-hour and quarter hour

2010-12-12 Thread Anne-Marie Mahfouf
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6108/#review9214 --- A few remarks after a quick look: - you should not leave the debu

Review Request: The clock applet chiming per hour, half-hour and quarter hour

2010-12-12 Thread Sunny Sharma
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6108/ --- Review request for Plasma, Aaron Seigo and Anne-Marie Mahfouf. Summary -

Review Request: Use correct pixmap cache file for theme

2010-12-12 Thread Manuel Mommertz
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6100/ --- Review request for Plasma. Summary --- Currently when switching themes,

Re: Compile Failure

2010-12-12 Thread Marco Martin
On Sun, Dec 12, 2010 at 2:53 AM, Steven Sroka wrote: > I'm trying to compile kdebase and I keep getting this compile error: > /kdebase/workspace/libs/plasmaclock/calendartable.cpp:853:54: error: ‘class > KHolidays::HolidayRegionSelector’ has no member named ‘setRegionUseFlags’ > My copy of trunk i