Re: Review Request: Notes widget: Working bold/italic/underline/strike out even when the note text is empty

2010-11-29 Thread Aaron Seigo
> On 2010-11-30 01:04:03, Davide Bettio wrote: > > Should we apply this patch while waiting someone who fix this bug in Qt? sure (if only because the bug has been closed as "out of scope"), but annotate the code with a comment explaining the situation and a link to the bug report on the qt bug

Re: Review Request: Notes widget: Working bold/italic/underline/strike out even when the note text is empty

2010-11-29 Thread Davide Bettio
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6005/#review9050 --- Should we apply this patch while waiting someone who fix this bug

Re: Desktop Slideshow Settings

2010-11-29 Thread Aaron J. Seigo
On Monday, November 29, 2010, Steven Sroka wrote: > Pic of window and buttons attached. I think it is created in image.cpp aha. the ok/apply/cancel buttons. (this is one time when a picture was only worth 5 words. ;) those are handled automatically by KConfigDialog. when the settingsChanged sig

Re: The KWin Coding Style Situation

2010-11-29 Thread Zack Rusin
On Monday 29 November 2010 17:09:35 Matthias Fuchs wrote: > Am Montag 29 November 2010, 17:57:45 schrieb Fredrik Höglund: > > I'm pretty sure Aaron meant annotate when he said bisect. > > Yes that would indeed be a problem. > I have no clue if there would be a way around this without inflicting mo

Re: Review Request: Turns the slide effect off if KRunner is set to floating.

2010-11-29 Thread Matthias Fuchs
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6006/ --- (Updated 2010-11-29 22:22:14.795984) Review request for kwin and Plasma. C

Re: Desktop Slideshow Settings

2010-11-29 Thread Aaron J. Seigo
On Monday, November 29, 2010, Steven Sroka wrote: > I'm trying to change some configurations with the KDE desktop sideshow, but > I can't figure out where the code is to control the buttons on the window, which buttons on which window? -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B

Re: The KWin Coding Style Situation

2010-11-29 Thread Matthias Fuchs
Am Montag 29 November 2010, 17:57:45 schrieb Fredrik Höglund: > On Monday 29 November 2010, Matthias Fuchs wrote: > > Am Sonntag 28 November 2010, 22:48:56 schrieb Aaron J. Seigo: > > > so yes, a reformat will create an "opaque membrane" in the history of > > > the repository, but wether that is ac

Re: Review Request: The KSystemActivityDialog uses MB as default unit.

2010-11-29 Thread Sebastian Kügler
On Monday, November 29, 2010 22:25:29 Matthias Fuchs wrote: > What do you think on the idea I mentioned above, i.e. not using one "size" > (KB, MB), but those that fit best, like in Dolphin? Actually only if it is > possible from an implementation point of view (is BC/SC needed here?) How do you m

Re: Review Request: The KSystemActivityDialog uses MB as default unit.

2010-11-29 Thread Matthias Fuchs
> On 2010-11-29 15:50:28, Sebastian Kügler wrote: > > The unit used should probably be the global KDE setting, as described in: > > > > http://api.kde.org/4.x-api/kdelibs-apidocs/kdecore/html/classKLocale.html#a42d678b641fde94ba12b89e4e4472a83 > > > > I'm myself not really happy with the MiB no

Desktop Slideshow Settings

2010-11-29 Thread Steven Sroka
I'm trying to change some configurations with the KDE desktop sideshow, but I can't figure out where the code is to control the buttons on the window, funny enough. The code is here: http://websvn.kde.org/trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/

Re: JavaScript Widget: nativeWidget for LineEdit

2010-11-29 Thread Aaron J. Seigo
On Monday, November 29, 2010, Thomas wrote: > @input_number.nativeWidget().setCompletedItems(matches, true) nativeWidget() is not supported, no. the reason for this is to keep the bindings small (better runtime performance (particularly startup) and easier to learn) and to ensure we could be sat

Re: Review Request: Notes widget: Working bold/italic/underline/strike out even when the note text is empty

2010-11-29 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6005/#review9041 --- More likely a Qt Bug. Seems similar to this one which I filed a fe

Re: Review Request: Display applet context menu when the label hasn't any context menu to show.

2010-11-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6009/#review9040 --- Ship it! i think it could work. let's see how it goes trunk/KDE

Review Request: Display applet context menu when the label hasn't any context menu to show.

2010-11-29 Thread Davide Bettio
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6009/ --- Review request for Plasma. Summary --- If there isn't any label context

Re: Review Request: The KSystemActivityDialog uses MB as default unit.

2010-11-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6007/#review9038 --- The unit used should probably be the global KDE setting, as descri

JavaScript Widget: nativeWidget for LineEdit

2010-11-29 Thread Thomas
Hi all, I'm new to this mailing list, sebas told me to post my issue to this list, so here it is :) I'm writing a js widget to send texts (over the internet) to mobile devices. (I've done this already in ruby and I'm now porting to javascript, because I had some issues with the ruby plasma API

Re: The KWin Coding Style Situation

2010-11-29 Thread Matthias Fuchs
Am Sonntag 28 November 2010, 22:48:56 schrieb Aaron J. Seigo: > so yes, a reformat will create an "opaque membrane" in the history of the > repository, but wether that is actually a problem or not comes down to the > development practices around kwin. e.g. how important is it to git bisect N > mont

Re: The KWin Coding Style Situation

2010-11-29 Thread Matthias Fuchs
Am Sonntag 28 November 2010, 22:48:56 schrieb Aaron J. Seigo: > so yes, a reformat will create an "opaque membrane" in the history of the > repository, but wether that is actually a problem or not comes down to the > development practices around kwin. e.g. how important is it to git bisect N > mont