KRunner Crash BuG:207592

2010-11-27 Thread Matthias Fuchs
Hi, I was looking at that bug and I am not sure if we should try to fix this. If we would though I would see two ways: 1. do not call save in KBookmarkManager::parse() -- not sure what the consequences would be 2. adding a method to KBookmarkManager to disable the dialog Personally I don't like

Review Request: Fixes QuickSand scrolling animation

2010-11-27 Thread Matthias Fuchs
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5988/ --- Review request for Plasma. Summary --- If an animation is already runni

Re: Using Plasma::Svg outside of Plasma

2010-11-27 Thread Manuel Mommertz
On Saturday 27 November 2010 19:33:13 Aaron J. Seigo wrote: > using Plasma::Svg with a SVG file that is not in the theme, the theme's > color scheme is applied? exactly > if so, that's a bug, and easily fixed (by not applying the colors to SVGs > that are !d->themed). Way better then my idea.

Re: Review Request: Supports KDE3 way of starting man/info-pages

2010-11-27 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5985/#review9008 --- Ship it! the logic looks fine, but calling it "kde3Shortcut" is n

Re: Using Plasma::Svg outside of Plasma

2010-11-27 Thread Aaron J. Seigo
On Saturday, November 27, 2010, Manuel Mommertz wrote: > as you all know, Plasma::Svg is not only used by Plasma itself but by > external apps like aurorae too. While this works pretty well in most cases > it still uses Plasma::Theme which can lead to annoying behavior. For > example if the SVG wan

Review Request: Supports KDE3 way of starting man/info-pages

2010-11-27 Thread Matthias Fuchs
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5985/ --- Review request for Plasma and Teemu Rytilahti. Summary --- Supports KDE

Using Plasma::Svg outside of Plasma

2010-11-27 Thread Manuel Mommertz
Hey, as you all know, Plasma::Svg is not only used by Plasma itself but by external apps like aurorae too. While this works pretty well in most cases it still uses Plasma::Theme which can lead to annoying behavior. For example if the SVG want to use the current colorscheme. In this case the col

Re: Plasma themes set in kdeartwork

2010-11-27 Thread Ivan Čukić
Ok, plasma ppl agreed on replacing the unmaintained ones: Clean-Blend Elegance Silicon heron Nuno and myself are volunteering to choose the replacements. Is anybody else willing to join us? If we want to change them for 4.6, we have until 20. 12. (hard message and artwork freeze) Cheeri

Re: Plasma themes set in kdeartwork

2010-11-27 Thread Ivan Čukić
Ok, since you've agreed and forgot to include kdeartists list into the discussion, I'll send them a nudge to make some kind of jury (Nuno, me, and possibly someone else). Anybody from plasma interested in judging? -- Cheerio, Ivan -- While you were hanging yourself on someone else's words Dying

Re: Plasma themes set in kdeartwork

2010-11-27 Thread Marco Martin
On 11/26/10, Aaron J. Seigo wrote: > On Friday, November 26, 2010, Ivan Cukic wrote: >> Aaron's stance some time ago was that we shouldn't remove them because it >> would mean problems for users of those themes. > > this has changed a bit since then as we now have a nice working fallback > system