Re: Review Request: Kickoff application uninstaller

2010-11-25 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5974/#review8981 --- Ship it! a comment in the code explaining why an activatable is b

Re: Review Request: Kickoff application uninstaller

2010-11-25 Thread Aaron Seigo
> On 2010-11-25 23:51:56, Aaron Seigo wrote: > > /trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp, > > lines 104-117 > > > > > > this would be better with a QDBusServiceWatcher (f

Re: Review Request: Kickoff application uninstaller

2010-11-25 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5974/#review8979 --- looks good (for 4.7), with the exception of using QDBusServiceWatc

Re: Review Request: Kickoff application uninstaller

2010-11-25 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5974/ --- (Updated 2010-11-25 23:48:05.415571) Review request for Plasma. Changes --

Re: Review Request: Kickoff application uninstaller

2010-11-25 Thread Daniel Nicoletti
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5974/ --- (Updated 2010-11-25 23:44:39.182743) Review request for Plasma and Aaron Sei

summary of the Nov 24th git migration meeting

2010-11-25 Thread Aaron J. Seigo
hi all ... i put together a summary of yesterday's meeting here: http://community.kde.org/Plasma/20101125 it's linked to from the usual Meetings section on the main Plasma community wiki page as well. please read it for accuracy, provide corrections and additions as

Re: irc meeting on the 22nd: git workflow, git and kdebase-workspace

2010-11-25 Thread Riccardo Iaconelli
On Monday 22 November 2010 19:22:32 Aaron J. Seigo wrote: > i will be hosting a discussion wednesday the 22nd at 18:00 UTC in #plasma > about git and our projects. Do we have any logs or summary of the meeting? :) Bye, -Riccardo signature.asc Description: This is a digitally signed message par

Re: Location dataengine is broken

2010-11-25 Thread Vitor Boschi
Hi, http://ipinfodb.com/ip_query.php is the actual address being used by the dataengine. The problem is that they started to require an API key in order to answer requests. The key is free, but I'm not sure that we can use it in our application, so I'm going to send an email to ask them and will r

Location dataengine is broken

2010-11-25 Thread Artur de Souza
Hello :) It seems that the "ip location tools" service does not provide the same API as before. So the page that we are using: http://iplocationtools.com/ip_query.php Does not exist anymore. Anybody willing to fix this? (Or is anybody the maintainer of that engine?) Otherwise I could take a l