Re: Review Request: Launchersupport in libtaskmanager - final implementation

2010-11-10 Thread Marco Martin
> On 2010-11-07 18:07:13, Aaron Seigo wrote: > > trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.cpp, line 316 > > > > > > the fact that his can fail hints that this is a feature in the wrong > > place. > >

Re: Review Request: Launchersupport in libtaskmanager - final implementation

2010-11-10 Thread Marco Martin
> On 2010-11-07 18:07:13, Aaron Seigo wrote: > > trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.cpp, lines 305-312 > > > > > > why "Pin Task"? that doesn't really tell me what it does at all. what > > it re

Re: Review Request: Plasma doesn't follow Kiosk restrictions

2010-11-10 Thread Marco Martin
> On 2010-11-10 17:30:41, Chani Armitage wrote: > > no, I don't think this is correct. > > > > check out line 880: > > ImmutabilityType Applet::immutability() const > > that function doesn't return d->immutability, but the strongest of that and > > various other checks. and it suggests that Cor

Re: Review Request: Launchersupport in the Tasks-applet

2010-11-10 Thread Todd
> On 2010-11-09 21:11:41, Todd wrote: > > Might it be a good idea to make tasks that have a launcher associated with > > them somehow visually distinct from those that don't? > > Anton Kreuzkamp wrote: > If you give me an idea how to indicate that a task has a launcher I can > do (it shoul

Re: Review Request: Plasma doesn't follow Kiosk restrictions

2010-11-10 Thread Chani Armitage
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5823/#review8624 --- no, I don't think this is correct. check out line 880: Immutabili

Re: Review Request: Plasma doesn't follow Kiosk restrictions

2010-11-10 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5823/#review8622 --- Ship it! looks fine trunk/KDE/kdelibs/plasma/applet.cpp

Plasmoids and monochrom icons (plasma-theme icons)

2010-11-10 Thread Nik Lutz
Hi Users of my plasmoid* are repeatingly asking for monochrom-icons: How can a plasmoid use the new plasma-theme-icons introduced in 4.5? http://techbase.kde.org/Development/Tutorials/Plasma/ThemeDetails mentions that applications should use setIconByName for their system-tray icons. But what ab

Review Request: Plasma doesn't follow Kiosk restrictions

2010-11-10 Thread Lubos Lunak
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5823/ --- Review request for Plasma and Marco Martin. Summary --- Probably as a r

Re: Default activities

2010-11-10 Thread Anne-Marie Mahfouf
On Wednesday 10 November 2010 11:01:41 Ivan Cukic wrote: > > speaking of bugfixing, the photos template has one already: if digikam > > isn't installed it still makes a (broken) digikam icon. can anyone think > > of a way to fix that? > > The photos template - if it doesn't work without digikam, i

Re: Review Request: Plasma: Folder View: Icon displays 'pressed' on non-activating clicks

2010-11-10 Thread Markus Slopianka
> On 2010-11-09 18:37:25, Aaron Seigo wrote: > > > > Lindsay Roberts wrote: > If there are no objections could I request that someone check this in? Does it change the behavior described in https://bugs.kde.org/show_bug.cgi?id=256465 (always using the large 256x256 icon for the scaling ef

Re: Re: Default activities

2010-11-10 Thread Ivan Cukic
> speaking of bugfixing, the photos template has one already: if digikam isn't > installed it still makes a (broken) digikam icon. can anyone think of a way > to > fix that? The photos template - if it doesn't work without digikam, it should be installed by digikam. If it does, but only show