Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

2010-10-28 Thread Ingomar Wesp
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/ --- (Updated 2010-10-28 23:30:24.052034) Review request for Plasma. Changes --

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

2010-10-28 Thread Ingomar Wesp
> On 2010-10-28 15:53:45, Marco Martin wrote: > > I'm still not sure wether this will be fast enough, but let's try it Great! Thanks for reviewing. Manuel sent me a few very good suggestions via PM and I noticed a low hanging performance fruit in SharedSvgRenderer::load, so I'm afraid there wi

Re: Review Request: activity templates

2010-10-28 Thread Chani Armitage
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5709/#review8417 --- wait, why did I post this? it's so trivial.. I'll just commit :)

Re: Review Request: activities dataengine

2010-10-28 Thread Albert Astals Cid
> On 2010-10-28 18:45:00, Albert Astals Cid wrote: > > Which of the strings you add here will be shown to the user? > > Chani Armitage wrote: > none... unless some plasmoid decides to dump the raw data straight to > widgets (which would be dumb in this case) or they're using > plasmaengine

Review Request: activity templates

2010-10-28 Thread Chani Armitage
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5709/ --- Review request for Plasma. Summary --- whee! this turned out to be quit

Re: Review Request: activities dataengine

2010-10-28 Thread Chani Armitage
> On 2010-10-28 18:45:00, Albert Astals Cid wrote: > > Which of the strings you add here will be shown to the user? none... unless some plasmoid decides to dump the raw data straight to widgets (which would be dumb in this case) or they're using plasmaengineexplorer (in which case they're a de

Re: Review Request: activities dataengine

2010-10-28 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5707/#review8414 --- Which of the strings you add here will be shown to the user? - Al

Re: KDE/kdebase/workspace/kwin

2010-10-28 Thread Anton Kreuzkamp
> > > > so... who's interested in making this happen? :) > > > > whoever it is gets a beer (and hugs of course!) next akademy :) > > >  > > > ...anyone? > >  > > I would volunteer as it is mostly the kwin part, but unfortunately hard > > feature freeze is already in two weeks and there are other t

Review Request: activities dataengine

2010-10-28 Thread Chani Armitage
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5707/ --- Review request for Plasma and Albert Astals Cid. Summary --- this is a

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

2010-10-28 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/#review8411 --- Ship it! I'm still not sure wether this will be fast enough, but

Re: Review Request: Adding filename as tooltip for frame applet

2010-10-28 Thread Sujith H
> On 2010-10-28 13:25:15, Anne-Marie Mahfouf wrote: > > It's fine. Maybe there should be a setting showing the tooltip or not, for > > example when a user has several picture frames the tooltip is shown on > > another one which can be annoying. > > Any feedback from other people about having i

Re: Review Request: Added System Wallpaper and My Downloaded Wallpaper checkboxes to sildeshow config

2010-10-28 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5705/ --- (Updated 2010-10-28 15:28:16.705030) Review request for Plasma and Davide Be

Review Request: Added System Wallpaper and My Downloaded Wallpaper checkboxes to sildeshow config

2010-10-28 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5705/ --- Review request for Plasma and Davide Bettio. Summary --- Diffs -

Re: KDE/kdebase/workspace/kwin

2010-10-28 Thread Martin Gräßlin
On Wednesday 27 October 2010 20:22:12 Chani wrote: > > > > we could put this menu code in libkworkspace and the menu methods in > > > > libtaskmanager would use those internally. everything that uses > > > > libtaskmanager currently also pulls in libkworkspace at some point or > > > > another, so i

Re: Review Request: Adding filename as tooltip for frame applet

2010-10-28 Thread Anne-Marie Mahfouf
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5660/#review8409 --- It's fine. Maybe there should be a setting showing the tooltip or