Re: Review Request: Fifteen puzzle config dialog upgrade

2010-10-12 Thread Anthony Bryant
> On 2010-10-12 08:21:53, Marco Martin wrote: > > I think those changes are good, i'm just not sure about the removal of the > > shuffle button. > > there should be at least a context button action with it, because should be > > possible to reshuffle it in any moment (i.e. want to start a new g

Re: Review Request: Plasma::IconWidget: Add support for constrained size hints

2010-10-12 Thread Ingomar Wesp
> On 2010-10-12 20:19:23, Marco Martin wrote: > > just looking at the code seems sensible so far, did you tested it > > extensively? did you find any misbehaviour? > > (will do it tomorrow anyways) > > if it appear to behave well i think it could be tried to make it go in > did you tested it e

Re: Review Request: Fifteen puzzle config dialog upgrade

2010-10-12 Thread Marco Martin
> On 2010-10-12 08:21:53, Marco Martin wrote: > > I think those changes are good, i'm just not sure about the removal of the > > shuffle button. > > there should be at least a context button action with it, because should be > > possible to reshuffle it in any moment (i.e. want to start a new g

Re: Review Request: Add call action to contact runner

2010-10-12 Thread Bart Visscher
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5604/ --- (Updated 2010-10-12 21:13:20.641432) Review request for Plasma. Changes --

Re: Review Request: Add call action to contact runner

2010-10-12 Thread Bart Visscher
> On 2010-10-12 08:23:52, Marco Martin wrote: > > sounds good, you should check if a phone application is available at all > > before showing the action tough > > Bart Visscher wrote: > There is no function to check in Akonadi. But it is still useful because > it displays the number and yo

Re: Review Request: Fifteen puzzle config dialog upgrade

2010-10-12 Thread Anthony Bryant
> On 2010-10-12 08:21:53, Marco Martin wrote: > > I think those changes are good, i'm just not sure about the removal of the > > shuffle button. > > there should be at least a context button action with it, because should be > > possible to reshuffle it in any moment (i.e. want to start a new g

Re: Review Request: Plasma::IconWidget: Add support for constrained size hints

2010-10-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5580/#review8102 --- just looking at the code seems sensible so far, did you tested it

Re: Review Request: Add call action to contact runner

2010-10-12 Thread Marco Martin
> On 2010-10-12 08:23:52, Marco Martin wrote: > > sounds good, you should check if a phone application is available at all > > before showing the action tough > > Bart Visscher wrote: > There is no function to check in Akonadi. But it is still useful because > it displays the number and yo

Re: Review Request: Add call action to contact runner

2010-10-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5604/#review8100 --- Ship it! too bad there isn't a check in akonadi for the applicati

Re: Review Request: Add call action to contact runner

2010-10-12 Thread Marco Martin
> On 2010-10-12 08:23:52, Marco Martin wrote: > > sounds good, you should check if a phone application is available at all > > before showing the action tough > > Bart Visscher wrote: > There is no function to check in Akonadi. But it is still useful because > it displays the number and yo

Re: Review Request: Fifteen puzzle config dialog upgrade

2010-10-12 Thread Marco Martin
> On 2010-10-12 08:21:53, Marco Martin wrote: > > I think those changes are good, i'm just not sure about the removal of the > > shuffle button. > > there should be at least a context button action with it, because should be > > possible to reshuffle it in any moment (i.e. want to start a new g

Re: Review Request: Fifteen puzzle config dialog upgrade

2010-10-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5608/#review8098 --- Ship it! - Marco On 2010-10-12 02:17:13, Anthony Bryant wrote:

Re: Review Request: Add call action to contact runner

2010-10-12 Thread Bart Visscher
> On 2010-10-12 08:23:52, Marco Martin wrote: > > sounds good, you should check if a phone application is available at all > > before showing the action tough There is no function to check in Akonadi. But it is still useful because it displays the number and you can dial it with another phone.

Re: Review Request: Fifteen puzzle config dialog upgrade

2010-10-12 Thread Anthony Bryant
> On 2010-10-12 08:21:53, Marco Martin wrote: > > I think those changes are good, i'm just not sure about the removal of the > > shuffle button. > > there should be at least a context button action with it, because should be > > possible to reshuffle it in any moment (i.e. want to start a new g

Re: Review Request: Add call action to contact runner

2010-10-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5604/#review8085 --- sounds good, you should check if a phone application is available

Re: Review Request: Fifteen puzzle config dialog upgrade

2010-10-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5608/#review8084 --- I think those changes are good, i'm just not sure about the remova

Review Request: Add call action to contact runner

2010-10-12 Thread Bart Visscher
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5604/ --- Review request for Plasma. Summary --- When a contact has a phonenumber