Re: render SVGs with system colors

2010-09-27 Thread Julian Bäume
moin, Am Dienstag, 28. September 2010, 06:46:08 schrieb Manuel Mommertz: > For now I am looking for comments on the idea itself and on the way this > affects the SVGs. I’ve seen something similar in libkdegames (look for KGameSvgDocument, somewhat different approach, but one could do similar th

Re: render SVGs with system colors

2010-09-27 Thread Manuel Mommertz
On Monday 27 September 2010 23:09:16 Aaron J. Seigo wrote: > ave you done any timings to test how long the DOM parsing takes on svgs we > have in the theme? Not yet. But I have still some ideas to reduce the overhead. As soon as I feel fine with the code, I will do some timings. > (i'd also rec

Re: render SVGs with system colors

2010-09-27 Thread Aaron J. Seigo
On Monday, September 27, 2010, Manuel Mommertz wrote: > So would do you think of this? Should we try to get something like this in > libplasma? Or is it to exotic? Maybe someone even has an idea how we can > archive this in a clean way. Let me know. :) i think the idea is good, and the overhead sh

Re: Review Request: Corona::exportLayout

2010-09-27 Thread Aaron J. Seigo
On Monday, September 27, 2010, Chani wrote: > > this should probably take a KConfigGroup, since KConfigGroup can > > refer > > > > to the top level item, e.g. the whole config file, using the magic > > QString() name for the group. > > the magic qstring thing means it takes two lines to c

Re: Review Request: Corona::exportLayout

2010-09-27 Thread Chani
> this should probably take a KConfigGroup, since KConfigGroup can refer > to the top level item, e.g. the whole config file, using the magic > QString() name for the group. > the magic qstring thing means it takes two lines to call exportLayout. what's the benefit?

Re: Review Request: Corona::exportLayout

2010-09-27 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5451/#review7839 --- Ship it! a few small things, but this can go in with the details

Re: Review Request: Corona::exportLayout

2010-09-27 Thread Aaron Seigo
> On 2010-09-26 20:22:05, Aaron Seigo wrote: > > trunk/KDE/kdelibs/plasma/corona.cpp, line 340 > > > > > > this should probably take a KConfigGroup, since KConfigGroup can refer > > to the top level item, e.g. the wh

Activity services merge

2010-09-27 Thread Ivan ?uki?
*** This is a cross-list-thread *** Hi all, I'm in the process of recreating the activity-related services and I'd like to merge the kded activities daemon and nepomuk activities service. Essentially, the current state is this: - kded activities daemon handles the data needed by workspaces (

Re: Review Request: Corona::exportLayout

2010-09-27 Thread Chani Armitage
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5451/ --- (Updated 2010-09-27 14:38:42.056313) Review request for Plasma. Changes --

Review Request: Do not use tree view for categories in the vertical widgets explorer

2010-09-27 Thread Anselmo Melo
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5446/ --- Review request for Plasma. Summary --- The propose here is to remove th

Re: Review Request: Use Plasma::ScrollWidget in the widget explorer

2010-09-27 Thread Anselmo Melo
> On 2010-09-24 10:43:08, Beat Wolf wrote: > > what is the status of this patch? > > Aurélien Gâteau wrote: > I need to ping someone so that it gets reviewed. I like this idea because it cleans the interface, specially in the vertical orientation. The patch need to be updated due to recent

Re: Review Request: Corona::exportLayout

2010-09-27 Thread Chani Armitage
> On 2010-09-26 20:22:05, Aaron Seigo wrote: > > trunk/KDE/kdelibs/plasma/corona.cpp, line 340 > > > > > > this should probably take a KConfigGroup, since KConfigGroup can refer > > to the top level item, e.g. the wh

Re: Review Request: Corona::exportLayout

2010-09-27 Thread Chani Armitage
> On 2010-09-26 20:22:05, Aaron Seigo wrote: > > trunk/KDE/kdelibs/plasma/corona.cpp, line 340 > > > > > > this should probably take a KConfigGroup, since KConfigGroup can refer > > to the top level item, e.g. the wh

Re: Review Request: Corona::exportLayout

2010-09-27 Thread Aaron Seigo
> On 2010-09-26 20:22:05, Aaron Seigo wrote: > > trunk/KDE/kdelibs/plasma/corona.cpp, lines 359-362 > > > > > > what does calling updateConstraints even do in this case? looking at > > the code in Applet, this just s

Re: Review Request: Corona::exportLayout

2010-09-27 Thread Chani Armitage
> On 2010-09-26 20:22:05, Aaron Seigo wrote: > > trunk/KDE/kdelibs/plasma/corona.cpp, lines 359-362 > > > > > > what does calling updateConstraints even do in this case? looking at > > the code in Applet, this just s