Re: Review Request: Better behaviour of the bookmarks runner regarding Firefox

2010-06-22 Thread Jan Gerrit Marker
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4414/ --- (Updated 2010-06-22 16:41:18.325281) Review request for Plasma. Changes --

Re: Review Request: Resubmit: Fix to game of life applet to avoid accessing memory outside bounds of array.

2010-06-22 Thread Marco Martin
> On 2010-06-21 14:59:37, Marco Martin wrote: > > good catch > > obby wrote: > Hi Marco, > > This is the first patch I've ever submitted to the review board. What's > the process like from here? I currently don't have a subversion account; will > another developer submit this patc

Re: Review Request: Better behaviour of the bookmarks runner regarding Firefox

2010-06-22 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4414/#review6240 --- /trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/bookmar

Re: Review Request: Twitter OAuth support for microblog dataengine

2010-06-22 Thread Ryan Bitanga
> On 2010-06-22 12:16:32, Marco Martin wrote: > > even if it can be seen as a feature it's pretty important that goes in > > asap, before 4.5 > > btw, looking at the patch they shouldn't, but did you see if doesn't > > interfere with identica? I look at it as more of a bugfix than a feature. T

Re: Review Request: Better behaviour of the bookmarks runner regarding Firefox

2010-06-22 Thread Jan Gerrit Marker
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4414/ --- (Updated 2010-06-22 15:16:45.874909) Review request for Plasma. Changes --

Re: Review Request: Resubmit: Fix to game of life applet to avoid accessing memory outside bounds of array.

2010-06-22 Thread Marco Martin
On Tuesday 22 June 2010, the.goofeed...@gmail.com wrote: > > On 2010-06-21 14:59:37, Marco Martin wrote: > > > good catch > > Hi Marco, > > This is the first patch I've ever submitted to the review board. What's the > process like from here? I currently don't have a subversion account; will > ano

Re: Review Request: Resubmit: Fix to game of life applet to avoid accessing memory outside bounds of array.

2010-06-22 Thread the . goofeedude
> On 2010-06-21 14:59:37, Marco Martin wrote: > > good catch Hi Marco, This is the first patch I've ever submitted to the review board. What's the process like from here? I currently don't have a subversion account; will another developer submit this patch? I'm hoping to become a regular con

Re: Review Request: Twitter OAuth support for microblog dataengine

2010-06-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4440/#review6230 --- Ship it! even if it can be seen as a feature it's pretty important th

Review Request: Twitter OAuth support for microblog dataengine

2010-06-22 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4440/ --- Review request for Plasma. Summary --- This patch adds oauth support for th

Re: Review Request: Twitter OAuth support for microblog dataengine

2010-06-22 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4440/ --- (Updated 2010-06-22 11:47:11.665544) Review request for Plasma. Summary --