Re: Review Request: Stop DataContainer from discarding multiple values for a single key.

2010-06-08 Thread Aaron J. Seigo
On June 8, 2010, Aaron J. Seigo wrote: > * revert the original commit completely; one key per hash ok, i've already done this... > * make the calendar dataengine work properly: put a QStringList in for the > duplicate dates. so instead of: looking at the calendar DataEngine, it is sending what

Re: Review Request: fix data leak in dataengines

2010-06-08 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4261/#review6047 --- John's commit should just be reverted and the calendar dataengine chan

Re: Review Request: frame plasmoid: allow to add (separate) picture files to slideshow

2010-06-08 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4256/#review6046 --- /trunk/KDE/kdeplasma-addons/applets/frame/imageSettings.ui

Re: Review Request: Stop DataContainer from discarding multiple values for a single key.

2010-06-08 Thread Aaron J. Seigo
On June 8, 2010, Beat Wolf wrote: > > On 2010-06-08 19:20:44, Marco Martin wrote: > > > this actually causes a memory escalation > > > > > > not actually a "leak" but in systemmonitor for instance each time a new > > > value arrives, will have a different one so the values will continue > > > to p

Re: Review Request: fix data leak in dataengines

2010-06-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4261/#review6044 --- Ship it! should work. is this new api necessary? - Marco On 2010-0

Review Request: fix data leak in dataengines

2010-06-08 Thread Beat Wolf
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4261/ --- Review request for Plasma. Summary --- fix the data "leak" introduced by ht

Re: Review Request: Stop DataContainer from discarding multiple values for a single key.

2010-06-08 Thread Beat Wolf
> On 2010-06-08 19:20:44, Marco Martin wrote: > > this actually causes a memory escalation > > > > not actually a "leak" but in systemmonitor for instance each time a new > > value arrives, will have a different one > > so the values will continue to pile up more and more i have here a patch t

Re: Review Request: Stop DataContainer from discarding multiple values for a single key.

2010-06-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4235/#review6040 --- this actually causes a memory escalation not actually a "leak" but in

Re: Notifications plasmoid, leak?

2010-06-08 Thread Aaron J. Seigo
On June 5, 2010, Asraniel wrote: > Related or not, but there was a problem that closing notifications would > also keep a file open, so after some time your icons would disapear > because too many files where open (might be totaly unreleated though) unrelated, and fixed -- Aaron J. Seigo humru o

Re: bug target for 4.5

2010-06-08 Thread Asraniel
Great! now one of the next steps is to actually fix some of the most reported plasma bugs, in order to not have too many dupes in the future. You can find them here: https://bugs.kde.org/duplicates.cgi?sortby=count&reverse=1&maxrows=100&changedsince=7&openonly=1&product=plasma Lets make that 4.

Review Request: frame plasmoid: allow to add (separate) picture files to slideshow

2010-06-08 Thread michal seben
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4256/ --- Review request for Plasma. Summary --- This patch enhance slideshow in fram

Re: Review Request: Plasma Mediacenter: Inroduce displaying and modifying of nepomuk tags

2010-06-08 Thread Markus Slopianka
> On 2010-06-07 22:45:45, Markus Slopianka wrote: > > Correct me if I missed anything, but as I skimmed through the diff, it > > looked to me that this is only about Nepomuk tags. Correct? > > I may be splitting hairs here, but when I hear "tag editing" in the context > > of media players, I th

Re: [Plasma Media Center] meeting planning

2010-06-08 Thread Marco Martin
On Monday 07 June 2010, Alessandro Diaferia wrote: > Hello list, > first of all i'd like to thank all of you for the hints you gave me. > > I feel it's time for the first PMC meeting as I've just detected some new > priorities to take care of. > I took the freedom to cross-post as such projects ar

Re: Review Request: Plasma Mediacenter: Inroduce displaying and modifying of nepomuk tags

2010-06-08 Thread Christophe Olinger
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4252/ --- (Updated 2010-06-08 08:03:13.711993) Review request for Plasma and Alessandro Di

Re: bug target for 4.5

2010-06-08 Thread Nicolas Lécureuil
Le jeudi 3 juin 2010 14:21:28, Asraniel a écrit : > Now that the bug target has been largely acheived, it would be nice to make > a new one. 600 perhaps? one can be dreaming :) your dream become true :) thanks to the great plasma team we are now to 589 bugs opened. Now we can dream of 500 bug a

Re: [Plasma Media Center] meeting planning

2010-06-08 Thread Shantanu Tushar Jha
I've exams for the coming two weeks, but will try to be present at whatever time is decided :) On 6/7/10, Alessandro Diaferia wrote: > Hello list, > first of all i'd like to thank all of you for the hints you gave me. > > I feel it's time for the first PMC meeting as I've just detected some new >