Re: Review Request: Add menu tooltips on simpleapplet

2010-05-20 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4082/#review5772 --- Ship it! needs some cleanup, but otherwise looks fine to me. /trunk

Re: Review Request: Plasma Mediacenter: Move tabbar and browsinig widgets into Browser

2010-05-20 Thread Alessandro Diaferia
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4050/#review5765 --- Just little annotations here and there. I like the way we're doing thi

Review Request: Add menu tooltips on simpleapplet

2010-05-20 Thread Nicolas Lécureuil
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4082/ --- Review request for Plasma. Summary --- This patch add tooltips when the use

Re: Review Request: Convert Plasma Calendar to use new KHolidays API

2010-05-20 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4079/#review5769 --- Ship it! ah, beautiful. i -hated- that code in the calendartable, but

Re: Review Request: Convert Plasma Calendar to use new KHolidays API

2010-05-20 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4079/#review5768 --- Ship it! ah, beautiful. i -hated- that code in the calendartable, but

Review Request: Convert Plasma Calendar to use new KHolidays API

2010-05-20 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4079/ --- Review request for Plasma. Summary --- In SC 4.5 KHolidays has a number of

Re: 4.5 changes for Plasmate

2010-05-20 Thread Aaron J. Seigo
On May 20, 2010, Yuen Hoe Lim wrote: > RunnerManager to allow it. I looked through DataEngineManager and it looks > like a similar patch would be necessary there too so that Plasmate's > previewer can load DataEngines without installing them. looks that way, yes. > I'm guessing > something like t

Re: QtScript handling callback functions with QScriptValue

2010-05-20 Thread Aaron J. Seigo
On May 20, 2010, Nikhil Marathe wrote: > void addEventListener(const QString &name, const QScriptValue > &function); > > implying that QScriptValue is used to 'collect' a function definition > (a callback) in the C++<->QtScript bridge. But when I am trying my own > code with something similar,

QtScript handling callback functions with QScriptValue

2010-05-20 Thread Nikhil Marathe
Hi, I am experimenting with QtScript and was looking at the Plasma JavaScript API for various examples. One particular is the addEventListener(name, func) on the global plasmoid object. The C++ implementation of addEventListener has a prototype void addEventListener(const QString &name, const

bizarre multiscreen crash

2010-05-20 Thread Chani
so I was trying to ensure views are always created when new screens appear... technically that was a success - but directly after creation I get this bizarre crash from the systray. it's happening very soon after PlasmaApp::createWaitingDesktops() returns, and *always* happens when a new deskto