Re: Review Request: Close notification with middle click

2010-04-24 Thread Martin Gräßlin
> On 2010-04-24 19:59:00, Aaron Seigo wrote: > > maybe we should make it possible to close any window by middle clicking on > > it so you don't have to click the small close button. ;) i really don't > > like these kinds of magic behaviours as there is no feedback to the user > > that the acti

Re: Review Request: Close notification with middle click

2010-04-24 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3802/#review5211 --- maybe we should make it possible to close any window by middle clickin

Re: Review Request: Close notification with middle click

2010-04-24 Thread Martin Gräßlin
> On 2010-04-24 19:20:39, Marco Martin wrote: > > i'm not sure it should really close it. > > it should just hide the automatic popup window i think > > (as it does already with left click after a second the mouse cursor hovered > > the notification) > > Marco Martin wrote: > I mean: in Not

Re: Review Request: Close notification with middle click

2010-04-24 Thread Marco Martin
> On 2010-04-24 19:20:39, Marco Martin wrote: > > i'm not sure it should really close it. > > it should just hide the automatic popup window i think > > (as it does already with left click after a second the mouse cursor hovered > > the notification) I mean: in NotificationStack::mouseReleaseEv

Re: Review Request: Close notification with middle click

2010-04-24 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3802/#review5208 --- i'm not sure it should really close it. it should just hide the automa

Review Request: Close notification with middle click

2010-04-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3802/ --- Review request for Plasma and Marco Martin. Summary --- Adding functionalit

KDE/kdebase/workspace/plasma/desktop/shell

2010-04-24 Thread Marco Martin
SVN commit 1118428 by mart: Two desktop views were getting created, as fix, do: - move the logic of desktop view creation in createWaitingDesktops - call createView upon containment creation only when the new containment is a panel CCMAIL:plasma-devel@kde.org M +35 -30plasmaapp.cpp --

Re: Review Request: [Quicklaunch] Refactoring of the Quicklaunch applet

2010-04-24 Thread Lukas Appelhans
Am Samstag 24 April 2010 12:45:16 schrieb Ingomar Wesp: > Lukas Appelhans wrote: > > For keeping the history we usually use svn copy and then change the files > > > > :) svn move only works with svn paths, not with local paths... > > Please correct me if I'm wrong, but as far as I know "svn move"

Re: Review Request: [Quicklaunch] Refactoring of the Quicklaunch applet

2010-04-24 Thread Ingomar Wesp
Lukas Appelhans wrote: > For keeping the history we usually use svn copy and then change the files > :) svn move only works with svn paths, not with local paths... Please correct me if I'm wrong, but as far as I know "svn move" *does* work for working copy paths and yields the same result as "svn

Re: Review Request: SkipSwitcher functionality

2010-04-24 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3800/#review5202 --- exactly what we wanted :) - Marco On 2010-04-24 10:16:21, Martin Gr

Review Request: SkipSwitcher functionality

2010-04-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3800/ --- Review request for Plasma, Aaron Seigo, Marco Martin, and Lubos Lunak. Summary -