Re: Review Request: Implemented Plasma::GaussianBlur effect

2010-04-20 Thread Richard Moore
On Tue, Apr 20, 2010 at 4:49 PM, Aaron Seigo wrote: >> On 2010-04-20 15:18:25, Richard Moore wrote: >> > Missing d pointer >> > When not move the function that allocates the gauss vector into the >> > private object? >> > > > it isn't a public class (none of the animations are), so a dptr isn't

Re: Review Request: Implemented Plasma::GaussianBlur effect

2010-04-20 Thread Aaron Seigo
> On 2010-04-20 15:18:25, Richard Moore wrote: > > Missing d pointer > > When not move the function that allocates the gauss vector into the private > > object? > > it isn't a public class (none of the animations are), so a dptr isn't actually needed in this case :) - Aaron ---

Re: Review Request: Implemented Plasma::GaussianBlur effect

2010-04-20 Thread Richard Moore
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3672/#review5119 --- Missing d pointer When not move the function that allocates the gauss

Re: Review Request: Implemented Plasma::GaussianBlur effect

2010-04-20 Thread Richard Moore
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3672/#review5118 --- Missing d pointer When not move the function that allocates the gauss

Re: Review Request: Implemented Plasma::GaussianBlur effect

2010-04-20 Thread Bruno Abinader
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3672/ --- (Updated 2010-04-20 15:07:52.234937) Review request for Plasma, Aaron Seigo, Mar

Re: Review Request: Return 80% functionality to PMC, further evolving of state architecture

2010-04-20 Thread Aaron Seigo
> On 2010-04-19 07:59:49, Alessandro Diaferia wrote: > > I just had a quick look at the patch, i'm rather busy atm :/ > > > > Anyway, i still have concerns about the subcomponents placement stuff. > > Rather than having WidgetAndZone approach imho we should enhance > > MediaController API in or

Re: Review Request: Return 80% functionality to PMC, further evolving of state architecture

2010-04-20 Thread Christophe Olinger
> On 2010-04-19 07:59:49, Alessandro Diaferia wrote: > > I just had a quick look at the patch, i'm rather busy atm :/ > > > > Anyway, i still have concerns about the subcomponents placement stuff. > > Rather than having WidgetAndZone approach imho we should enhance > > MediaController API in or

Re: Review Request: Return 80% functionality to PMC, further evolving of state architecture

2010-04-20 Thread Christophe Olinger
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3552/#review5115 --- I included some comments of the code so that we better see which parts