Re: Review Request: Allow StatusNotifierItem DBus objects to register with the StatusNotifierWatcher without creating a specific DBus service

2010-04-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3587/#review5039 --- Ship it! ok, go for it. don't forget to add in the spec at least a re

Re: Review Request: Allow StatusNotifierItem DBus objects to register with the StatusNotifierWatcher without creating a specific DBus service

2010-04-14 Thread Aurélien Gâteau
> On 2010-04-13 16:26:55, Marco Martin wrote: > > have you tested with an application registering two items? > > i would like keeping this possibility required in the specification and > > kmix needs it > > Aurélien Gâteau wrote: > No I haven't. I think it should still work though, since >

Re: Review Request: Allow StatusNotifierItem DBus objects to register with the StatusNotifierWatcher without creating a specific DBus service

2010-04-14 Thread Aurélien Gâteau
> On 2010-04-13 16:26:55, Marco Martin wrote: > > have you tested with an application registering two items? > > i would like keeping this possibility required in the specification and > > kmix needs it > > Aurélien Gâteau wrote: > No I haven't. I think it should still work though, since >

Re: KDE/kdeplasma-addons/applets/opendesktop

2010-04-14 Thread Sebastian Kügler
On Wednesday 14 April 2010 15:21:09 Sebastian Kügler wrote: > On Wednesday 14 April 2010 15:09:56 Frederik Gladhorn wrote: > > SVN commit 1114766 by gladhorn: > > > > remove debug output for css (why is this stuff in there in the first > > place?) > > It makes the text in the personal details wid

Re: Review Request: Return 80% functionality to PMC, further evolving of state architecture

2010-04-14 Thread Christophe Olinger
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3552/ --- (Updated 2010-04-14 13:52:37.746381) Review request for Plasma and Alessandro Di

Re: Review Request: Add libqalculate support to calculator runner

2010-04-14 Thread Alessandro Diaferia
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3483/#review5035 --- Ship it! Now that even whitespaces are over i'd say: go for it! - Al

Re: Review Request: Add libqalculate support to calculator runner

2010-04-14 Thread Matteo Agostinelli
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3483/ --- (Updated 2010-04-14 12:47:15.497906) Review request for Plasma and Aaron Seigo.

Re: Review Request: Allow StatusNotifierItem DBus objects to register with the StatusNotifierWatcher without creating a specific DBus service

2010-04-14 Thread Marco Martin
> On 2010-04-13 16:26:55, Marco Martin wrote: > > have you tested with an application registering two items? > > i would like keeping this possibility required in the specification and > > kmix needs it > > Aurélien Gâteau wrote: > No I haven't. I think it should still work though, since >

Re: Review Request: Allow StatusNotifierItem DBus objects to register with the StatusNotifierWatcher without creating a specific DBus service

2010-04-14 Thread Aurélien Gâteau
> On 2010-04-13 16:26:55, Marco Martin wrote: > > have you tested with an application registering two items? > > i would like keeping this possibility required in the specification and > > kmix needs it No I haven't. I think it should still work though, since RegisterStatusNotifierItem() can s

Re: Review Request: Add a little blur to the thumbnails to make it shine

2010-04-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3600/#review5033 --- Ship it! way nicer - Marco On 2010-04-14 10:23:27, Alessandro Diaf

Re: Review Request: Add a little blur to the thumbnails to make it shine

2010-04-14 Thread Alessandro Diaferia
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3600/ --- (Updated 2010-04-14 10:23:27.095840) Review request for Plasma. Changes --

Review Request: Add a little blur to the thumbnails to make it shine

2010-04-14 Thread Alessandro Diaferia
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3600/ --- Review request for Plasma. Summary --- I just found it a little weird witho