Re: Review Request: again on webview+scrollwidget

2010-03-25 Thread Zack Rusin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3399/#review4677 --- Ship it! Looking good, thanks for taking it all the way! The two whit

Re: Review Request: again on webview+scrollwidget

2010-03-25 Thread Zack Rusin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3399/#review4678 --- Ship it! Looking good, thanks for taking it all the way! The two whit

Re: Using DBusMenu in KStatusNotifierItem

2010-03-25 Thread Aaron J. Seigo
On March 25, 2010, Matthieu Gallien wrote: > Should I provide through the data engine, the description of the menu and a > service to trigger the actions (this solution would be more complicated) ? is it even possible to put the data in the engine? iirc, the menu can be populated on demand when

Re: Using DBusMenu in KStatusNotifierItem

2010-03-25 Thread Matthieu Gallien
Hello Plasma devs, I talked with Aurélien about this. Le Mardi 8 Décembre 2009 22:14:06, Marco Martin a écrit : > On Monday 07 December 2009, Aurélien Gâteau wrote: > > Hi, > > > > I have been talking with Marco and Aaron recently on a new way to define > > context menus for KStatusNotifierItem.

Review Request: again on webview+scrollwidget

2010-03-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3399/ --- Review request for Plasma. Summary --- this is 99% the zack's patch he sent

Re: MediaCenter Progress

2010-03-25 Thread Christophe Olinger
Thanks all for the suggestions. I'll make sure to try them all :-) On Thu, Mar 25, 2010 at 5:15 PM, Aaron J. Seigo wrote: > On March 25, 2010, Shantanu Tushar Jha wrote: >> If I'm understanding your question correctly, you just need to use >> "Update Diff" in reviewboard and upload the new diff.

Review Request: Initial work on the flexible controller of the Plasma Media Center

2010-03-25 Thread Christophe Olinger
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3396/ --- Review request for Plasma. Summary --- This patch extends the controller ap

Re: MediaCenter Progress

2010-03-25 Thread Aaron J. Seigo
On March 25, 2010, Shantanu Tushar Jha wrote: > If I'm understanding your question correctly, you just need to use > "Update Diff" in reviewboard and upload the new diff. there's also the great post-review tool: http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/ make sure you ha

Re: On Plasmate's previewer

2010-03-25 Thread Aaron J. Seigo
On March 24, 2010, Yuen Hoe Lim wrote: > Awesome :) will update trunk and try it out. Will this be backported to > 4.4.2 though? doubtful; the changes aren't trivial and i really don't like backporting things that aren't strictly bug fixes, and proven-to-be-correct ones :/ > And I'm having anoth

Re: MediaCenter Progress

2010-03-25 Thread Shantanu Tushar Jha
On Thu, Mar 25, 2010 at 6:49 PM, Christophe Olinger wrote: > Hey, > > I have a probably very stupid svn question: > If I submit my patch, how do I continue working on my project until > the patch is accepted?. I suppose I still need to change things in the > patch before it can go into playground.

Re: MediaCenter Progress

2010-03-25 Thread Alessandro Diaferia
2010/3/25 Christophe Olinger > Hey, > > I have a probably very stupid svn question: > If I submit my patch, how do I continue working on my project until > the patch is accepted?. I suppose I still need to change things in the > patch before it can go into playground. How do I send you guys a new

Re: MediaCenter Progress

2010-03-25 Thread Christophe Olinger
Hey, I have a probably very stupid svn question: If I submit my patch, how do I continue working on my project until the patch is accepted?. I suppose I still need to change things in the patch before it can go into playground. How do I send you guys a new patch without the changes that I have don

Re: MediaCenter Progress

2010-03-25 Thread Shantanu Tushar Jha
On Thu, Mar 25, 2010 at 1:41 PM, Christophe Olinger wrote: > Hey Shaan and Alessandro, > > How are you doing? Hacking on PMC goes well and I hope I can submit > the patch this evening or tomorrow. I implemented the following: > - the top panel now has 6 possible layouts (7 if you count the home >

MediaCenter Progress

2010-03-25 Thread Christophe Olinger
Hey Shaan and Alessandro, How are you doing? Hacking on PMC goes well and I hope I can submit the patch this evening or tomorrow. I implemented the following: - the top panel now has 6 possible layouts (7 if you count the home screen layout) - it has 4 buttons: Home, BrowsingPictures, BrowsingVide