Re: Review Request: flicking of WebView with ScrollWidget

2010-03-23 Thread Zack Rusin
On Tuesday 23 March 2010 13:53:24 Marco Martin wrote: > in that way the whole webview would flick instead of the webview contents? > (webview could also be resized to the whole contents but this would be > terribly inefficient right?) Ah, I see, that's the core of the issue. Yea, the scrolling o

Re: Running queries via dbus

2010-03-23 Thread Alex Merry
On Tuesday 23 March 2010 23:47:10 Jacopo De Simoi wrote: > I just got a quite crazy idea; it might work though. > Since we are making the thread stall by waiting for the async reply we > could as well check that while we get the pending reply the context is > still valid and bail out discarding the

Re: Running queries via dbus

2010-03-23 Thread Jacopo De Simoi
I just got a quite crazy idea; it might work though. Since we are making the thread stall by waiting for the async reply we could as well check that while we get the pending reply the context is still valid and bail out discarding the reply otherwise. If this can be coded in a simple way I gues

Re: On Plasmate's previewer

2010-03-23 Thread Aaron J. Seigo
On March 23, 2010, Aaron J. Seigo wrote: > in this model, Plasma::RunnerManager::addRunner would have two versions: > one that takes a KService and expects it to be installed and one that > takes a path to a package and behaves like Applet::loadPlasmoid. committed as RunnerManager::loadRunner... s

Re: Running queries via dbus

2010-03-23 Thread Jacopo De Simoi
> On Tuesday 23 March 2010 21:55:08 Alex Merry wrote: > > Instead, you should use QDBusConnection::asyncCall. This can be used in > > exactly the same way (implicit casting FTW), and casting to a QDBusReply > > will cause the calling thread to block as you would expect. But, > > importantly, it W

Re: Review Request: Fix taskmanager's "by desktop" sorting mode

2010-03-23 Thread Andreas Scherf
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3375/#review4645 --- trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/desktopsortin

Re: Running queries via dbus

2010-03-23 Thread Alex Merry
On Tuesday 23 March 2010 21:55:08 Alex Merry wrote: > Instead, you should use QDBusConnection::asyncCall. This can be used in > exactly the same way (implicit casting FTW), and casting to a QDBusReply > will cause the calling thread to block as you would expect. But, > importantly, it WON'T cause

Re: Review Request: Fix taskmanager's "by desktop" sorting mode

2010-03-23 Thread Asraniel
i think there is a bugreport about exactly what you describe. i can try to find it tomorrow Beat Wolf Am Dienstag 23 März 2010 23.36:43 schrieb Dmitry Suzdalev: > > On 2010-03-23 22:05:51, Aaron Seigo wrote: > > > so essentially it removes any sorting within the desktop sorting. i'm > > > fine wi

Re: Review Request: Fix taskmanager's "by desktop" sorting mode

2010-03-23 Thread Dmitry Suzdalev
> On 2010-03-23 22:05:51, Aaron Seigo wrote: > > so essentially it removes any sorting within the desktop sorting. i'm fine > > with that change (though perhaps others will now complain ;), though i have > > some thoughts below. Hmm, I just realized that some people might like to keep tasks su

Re: Running queries via dbus

2010-03-23 Thread Alex Merry
On Tuesday 23 March 2010 22:03:30 Jacopo De Simoi wrote: > > CC'ing plasma-devel, since this is an important point regarding runners > > that use D-Bus. Please keep any discussion on this issue at > > plasma-devel. > > > > On Tuesday 23 March 2010 17:26:54 Alex Merry wrote: > > > On Monday 22 Mar

Re: Review Request: Fix taskmanager's "by desktop" sorting mode

2010-03-23 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3375/#review4637 --- so essentially it removes any sorting within the desktop sorting. i'm

Re: Running queries via dbus

2010-03-23 Thread Jacopo De Simoi
> CC'ing plasma-devel, since this is an important point regarding runners that > use D-Bus. Please keep any discussion on this issue at plasma-devel. > > On Tuesday 23 March 2010 17:26:54 Alex Merry wrote: > > On Monday 22 March 2010 22:05:26 Jacopo De Simoi wrote: > > > > In particular, Meta::T

Re: Running queries via dbus

2010-03-23 Thread Alex Merry
CC'ing plasma-devel, since this is an important point regarding runners that use D-Bus. Please keep any discussion on this issue at plasma-devel. On Tuesday 23 March 2010 17:26:54 Alex Merry wrote: > On Monday 22 March 2010 22:05:26 Jacopo De Simoi wrote: > > > In particular, Meta::Track has flo

Re: Restart Plasma during package installation/upgrade

2010-03-23 Thread Aaron J. Seigo
On March 23, 2010, Rob Hasselbaum wrote: > Is there any way to restart Plasma as part of a package installation > or upgrade? yes, but i don't think you want to do this in this case. > I have a data engine that interacts with a D-Bus system > bus service, which gets installed at the same time. U

Re: Review Request: [Picture Frame] Update function for url's and configuration of download path

2010-03-23 Thread Aaron J. Seigo
On March 23, 2010, Sebastian Kügler wrote: > On Tuesday 23 March 2010 18:50:31 Aaron Seigo wrote: > > and the picture > > should always be overwritten (the frame plasmoid is not a downloader; see > > comments below for more on this). > > Currently, we prepend a number, so it doesn't overwrite. The

Re: Plasma Javascript Bindings inside QML

2010-03-23 Thread Marco Martin
On Tuesday 23 March 2010, Alexis Ménard wrote: > On Wed, Mar 24, 2010 at 4:15 AM, Marco Martin wrote: > > On Tuesday 23 March 2010, Aaron J. Seigo wrote: > >> On March 22, 2010, Alexis Ménard wrote: > >> > Hello, > >> > > >> > I just wonder which part of the Plasma bindings we want to put into >

Re: Plasma Javascript Bindings inside QML

2010-03-23 Thread Alexis Ménard
On Wed, Mar 24, 2010 at 4:15 AM, Marco Martin wrote: > On Tuesday 23 March 2010, Aaron J. Seigo wrote: >> On March 22, 2010, Alexis Ménard wrote: >> > Hello, >> > >> > I just wonder which part of the Plasma bindings we want to put into QML : >> > >> > http://techbase.kde.org/Development/Tutorials/

Re: Workaround in WebView...

2010-03-23 Thread Alexis Ménard
On Wed, Mar 24, 2010 at 3:35 AM, Aaron J. Seigo wrote: > On March 22, 2010, Alexis Ménard wrote: >> There are two crashes because of this workaround. >> >> One in QGV is fixed and is on its way to 4.6.3 >> >> The other is reported : >> >> https://bugs.kde.org/show_bug.cgi?id=227639 > > that looks

Review Request: Fix taskmanager's "by desktop" sorting mode

2010-03-23 Thread Dmitry Suzdalev
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3375/ --- Review request for Plasma. Summary --- This patch fixes a sorting order for

Restart Plasma during package installation/upgrade

2010-03-23 Thread Rob Hasselbaum
Is there any way to restart Plasma as part of a package installation or upgrade? I have a data engine that interacts with a D-Bus system bus service, which gets installed at the same time. Unfortunately, the data engine and applet don't start correctly when they're first installed. It seems the dat

Re: Review Request: [Quicklaunch] Refactoring, layout fixes and a drag & drop marker.

2010-03-23 Thread Lukas Appelhans
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3358/#review4633 --- Hey! First of all, I agree with pretty much all the points you noted!

Re: Review Request: [Quicklaunch] Refactoring, layout fixes and a drag & drop marker.

2010-03-23 Thread Lukas Appelhans
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3358/#review4632 --- Hey! First of all, I agree with pretty much all the points you noted!

Re: Review Request: [Picture Frame] Update function for url's and configuration of download path

2010-03-23 Thread Sebastian Kügler
On Tuesday 23 March 2010 18:50:31 Aaron Seigo wrote: > http://reviewboard.kde.org/r/3334/#review4627 > > personally, i don't see the need for a url configuration page at all. the > download path should be the from desktop-wide coniguration That's what it does right now QString path = KGlobalSett

Re: Plasma Javascript Bindings inside QML

2010-03-23 Thread Marco Martin
On Tuesday 23 March 2010, Aaron J. Seigo wrote: > On March 22, 2010, Alexis Ménard wrote: > > Hello, > > > > I just wonder which part of the Plasma bindings we want to put into QML : > > > > http://techbase.kde.org/Development/Tutorials/Plasma/JavaScript/API > > > > All the UI related stuff is p

datetime runner moved to kdereview

2010-03-23 Thread Aaron J. Seigo
hi... i moved a small runner plugin called "datetime" to kdereview today. i'd like to add it to the kdeplasma-addons/runners for SC 4.5. it supports the following kinds of queries: date date london date cest time time toronto time pst -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint:

Re: Workaround in WebView...

2010-03-23 Thread Kenneth Christiansen
I will try to search for it :-) I get hundreds of bug e-mails per day :-) Kenneth On Tue, Mar 23, 2010 at 2:51 PM, Aaron J. Seigo wrote: > On March 23, 2010, Kenneth Christiansen wrote: >> Would be nice if you could point out there places you found it to be >> using the QGraphicsView wrongly. So

Re: Review Request: flicking of WebView with ScrollWidget

2010-03-23 Thread Marco Martin
> On 2010-03-23 17:00:12, Zack Rusin wrote: > > /trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp, line 1179 > > > > > > Why was this needed? If we'll filter all child events then it will be > > possible to flick the s

Re: Workaround in WebView...

2010-03-23 Thread Aaron J. Seigo
On March 23, 2010, Kenneth Christiansen wrote: > Would be nice if you could point out there places you found it to be > using the QGraphicsView wrongly. Some of the issues are due to us > having to keep supporting QWebView which can make it tricky at times, > so if you find any issue, please let us

Re: Review Request: [Picture Frame] Update function for url's and configuration of download path

2010-03-23 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3334/#review4627 --- personally, i don't see the need for a url configuration page at all.

Re: Workaround in WebView...

2010-03-23 Thread Kenneth Christiansen
Would be nice if you could point out there places you found it to be using the QGraphicsView wrongly. Some of the issues are due to us having to keep supporting QWebView which can make it tricky at times, so if you find any issue, please let us know. Kenneth > i did. with code showing the problem

Re: Plasma Javascript Bindings inside QML

2010-03-23 Thread Aaron J. Seigo
On March 22, 2010, Alexis Ménard wrote: > Hello, > > I just wonder which part of the Plasma bindings we want to put into QML : > > http://techbase.kde.org/Development/Tutorials/Plasma/JavaScript/API > > All the UI related stuff is pretty much useless because QML provides > those facilities. It w

Re: Workaround in WebView...

2010-03-23 Thread Aaron J. Seigo
On March 22, 2010, Alexis Ménard wrote: > There are two crashes because of this workaround. > > One in QGV is fixed and is on its way to 4.6.3 > > The other is reported : > > https://bugs.kde.org/show_bug.cgi?id=227639 that looks a lot like a bug in QGraphicsView as well: it's crashing in the b

Re: On Plasmate's previewer

2010-03-23 Thread Aaron J. Seigo
On March 20, 2010, Yuen Hoe Lim wrote: > Hmmm, so I've been looking at the runner-related classes in Plasma::. Is it > possible at the moment to load (say make an AbstractRunner out of) a > scripted runner without installing it, a'la Applet::loadPlasmoid for > applets? I can't seem to find a way to

Re: Review Request: flicking of WebView with ScrollWidget

2010-03-23 Thread Zack Rusin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3368/#review4626 --- /trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp

Review Request: flicking of WebView with ScrollWidget

2010-03-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3368/ --- Review request for Plasma. Summary --- after the last modifications by Zack

Review Request: [Quicklaunch] Refactoring, layout fixes and a drag & drop marker.

2010-03-23 Thread Ingomar Wesp
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3358/ --- Review request for Plasma. Summary --- Ok, this is a biggie (and still a wo