Re: Review Request: Don't connect the same signals to the same slots for the same objects several times.

2010-03-04 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3142/#review4385 --- while the patch is fine, the real question is why is StartupCompleted

Review Request: Don't connect the same signals to the same slots for the same objects several times.

2010-03-04 Thread Espen Hustad
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3142/ --- Review request for Plasma. Summary --- Applet::flushPendingConstraintsEvent

Re: Review Request: Manual panel hiding [WIP]

2010-03-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3121/#review4384 --- /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelview.cpp

Re: Review Request: Manual panel hiding [WIP]

2010-03-04 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3121/#review4383 --- good start; looks fairly straightforward from here, i think. /trunk/

Re: Review Request: Plasma::Wallpaper: use a QRunnable thread to save the image in the cache.

2010-03-04 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3123/#review4381 --- Ship it! nice idea :) - Aaron On 2010-03-04 20:16:49, Davide Betti

Review Request: Plasma::Wallpaper: use a QRunnable thread to save the image in the cache.

2010-03-04 Thread Davide Bettio
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3123/ --- Review request for Plasma. Summary --- This patch avoid to block plasma whi

Re: Review Request: Manual panel hiding [WIP]

2010-03-04 Thread Andrzej JR Hunt
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3121/#review4378 --- Sorry, I've just noticed that there have been some changes to some of

Re: Manual Hiding of Plasma Panel (desktop shell)

2010-03-04 Thread Andrzej JR Hunt
On Thursday 04 March 2010 18:15:33 Aaron J. Seigo wrote: > > would you be able to upload a patch to reviewboard.kde.org so we can also > try it and comment on it directly? (if you don't feel it's ready for that > quite yet, that's cool; but when it is, please do so..) > > my thinking on the positi

Review Request: Manual panel hiding [WIP]

2010-03-04 Thread Andrzej JR Hunt
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3121/ --- Review request for Plasma. Summary --- Manual panel hiding patch (still in

Re: Manual Hiding of Plasma Panel (desktop shell)

2010-03-04 Thread Aaron J. Seigo
On March 4, 2010, Andrew Hunt wrote: > Hi all, > > I'm currently working on adding manual panel hiding to the plasma dektop > panel. ( https://bugs.kde.org/show_bug.cgi?id=158556 for more info.) > > Progress has gone quite well, here are a few screens (cut and combined into > one file): > http://

Re: feature plan

2010-03-04 Thread Marco Martin
On Thursday 04 March 2010, Aaron J. Seigo wrote: > On March 3, 2010, Chani wrote: > > after all that fun planning at tokamak, it's time we updated the feature > > plan for 4.5 :) > > ah, yes, thanks for bringing this up. > > i think we should also do what we used to do before Tokamak came along:

Re: feature plan

2010-03-04 Thread Aaron J. Seigo
On March 3, 2010, Chani wrote: > after all that fun planning at tokamak, it's time we updated the feature > plan for 4.5 :) ah, yes, thanks for bringing this up. i think we should also do what we used to do before Tokamak came along: have an irc meeting to discuss this. Tokamak has become an aw

Re: Review Request: The WebshortcutRunner did not check whether the search engines it provided were even enabled.

2010-03-04 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3097/#review4375 --- Ship it! looks great, and certainly an improvement in many ways. than

Re: Review Request: The WebshortcutRunner did not check whether the search engines it provided were even enabled.

2010-03-04 Thread Nikolaus Waxweiler
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3097/ --- (Updated 2010-03-04 15:34:42.916721) Review request for Plasma. Changes --

Manual Hiding of Plasma Panel (desktop shell)

2010-03-04 Thread Andrew Hunt
Hi all, I'm currently working on adding manual panel hiding to the plasma dektop panel. ( https://bugs.kde.org/show_bug.cgi?id=158556 for more info.) Progress has gone quite well, here are a few screens (cut and combined into one file): http://img697.imageshack.us/img697/5606/manualpanel2.png I