Re: Review Request: Add simple Type-and-Select feature to Folderview applet

2010-01-21 Thread Fredrik Höglund
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2659/#review3783 --- The code looks good, but I'm slightly concerned about the usability as

Re: Review Request: Add simple Type-and-Select feature to Folderview applet

2010-01-21 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2659/#review3781 --- trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp

Re: clarification on bug 223684, proposed patch

2010-01-21 Thread Aaron J. Seigo
On January 21, 2010, Riccardo Iaconelli wrote: > hello! > I have been reported this bug > https://bugs.kde.org/show_bug.cgi?id=223684 yesterday, via private > mail, and I asked the guy to open a bug in bugzilla. > you can read the description there, it looks like a really simple > problem with the

Re: QCompleter on Plasma::LineEdit not working properly

2010-01-21 Thread Aaron J. Seigo
On January 21, 2010, Cyrill Helg wrote: > On Tuesday 19 January 2010 21:42:23 Aaron J. Seigo wrote: > > On January 19, 2010, Cyrill Helg wrote: > > > On Tuesday 19 January 2010 21:13:01 Aaron J. Seigo wrote: > > > > On January 19, 2010, Cyrill Helg wrote: > > > Its qt 4.6 from gentoo official porta

Re: configChanged()

2010-01-21 Thread Riccardo Iaconelli
On Tue, Jan 19, 2010 at 8:46 AM, Aaron J. Seigo wrote: > *sigh* > > so i realized with a start this evening that virtually none of our Plasmoids > implement configChanged(). this means that the plasma-desktop js scripting is > going to be nearly useless with most of them in terms of setting the >

clarification on bug 223684, proposed patch

2010-01-21 Thread Riccardo Iaconelli
hello! I have been reported this bug https://bugs.kde.org/show_bug.cgi?id=223684 yesterday, via private mail, and I asked the guy to open a bug in bugzilla. you can read the description there, it looks like a really simple problem with the string returned by prettyTimezone(). however, I am not sure

Re: QCompleter on Plasma::LineEdit not working properly

2010-01-21 Thread Cyrill Helg
On Tuesday 19 January 2010 21:42:23 Aaron J. Seigo wrote: > On January 19, 2010, Cyrill Helg wrote: > > On Tuesday 19 January 2010 21:13:01 Aaron J. Seigo wrote: > > > On January 19, 2010, Cyrill Helg wrote: > > > > Its qt 4.6 from gentoo official portage unstale (4.6.0-r2) > > erf. 4.6.0 has a n