Re: Review Request: Draft: Widgets Explorer "Add Widgets"

2009-11-18 Thread Chani
> > Another issues: > * I'm missing remove and about buttons. At least about dialog would be > important for kde-look.org plasmoids. Is the Applet info popup right place > for those? where that uninstall button is? yeah, iirc that was where they were going to go > * Could the icons have two ro

Re: Review Request: Draft: Widgets Explorer "Add Widgets"

2009-11-18 Thread Petri Damstén
On Tuesday 17 November 2009 11:01:40 Marco Martin wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2191/#review3141 > --- > > >

Re: Review Request: Aspect Ratio Modes in Plasma::Dialog

2009-11-18 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2202/#review3165 --- Ship it! - Aaron On 2009-11-18 11:13:11, Giulio Camuffo wrote: > >

Re: Review Request: Aspect Ratio Modes in Plasma::Dialog

2009-11-18 Thread Aaron Seigo
> On 2009-11-18 01:25:47, Aaron Seigo wrote: > > /trunk/KDE/kdelibs/plasma/dialog.cpp, line 253 > > > > > > a switch statement might be more evident / natural? it would also give > > us compiler warnings if we forget a m

Review Request: Port Kinetic Scrolling to Qt 4.6

2009-11-18 Thread igorto
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2205/ --- Review request for Plasma, Marco Martin and Adenilson Cavalcanti. Summary --

Re: Review Request: Aspect Ratio Modes in Plasma::Dialog

2009-11-18 Thread Giulio Camuffo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2202/ --- (Updated 2009-11-18 11:13:11.294927) Review request for Plasma. Changes --

Re: Review Request: Aspect Ratio Modes in Plasma::Dialog

2009-11-18 Thread Giulio Camuffo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2202/ --- (Updated 2009-11-18 11:10:35.674293) Review request for Plasma. Changes --

Re: Review Request: Aspect Ratio Modes in Plasma::Dialog

2009-11-18 Thread Giulio Camuffo
> On 2009-11-18 01:25:47, Aaron Seigo wrote: > > good idea; just a few tweaks needed. > > > > "But if the applet changes its ratio mode while the dialog is being > > displayed it won't be get." > > > > the way to accomplish this is to modify the implementation of > > Applet::setAspectRatioMod