Re: Review Request: wetter.com Weather Ion

> On 2009-11-03 17:31:01, Will Stephenson wrote: > > You could work out the "Current Conditions" and "Condition Icon" data on > > each update using the current system time and the UTC time in the forecast > > periods, and set these on the data source. This would AFAICS get rid of > > the 'mis

Re: Review Request: wetter.com Weather Ion

> On 2009-11-03 17:31:01, Will Stephenson wrote: > > You could work out the "Current Conditions" and "Condition Icon" data on > > each update using the current system time and the UTC time in the forecast > > periods, and set these on the data source. This would AFAICS get rid of > > the 'mis

Re: Review Request: wetter.com Weather Ion

> On 2009-11-03 17:00:51, Will Stephenson wrote: > > /trunk/kdereview/plasma/dataengines/weather/ions/ion_wettercom.cpp, line 44 > > > > > > By convention, public member variables of pimpl classes are not names > > with m

Re: Review Request: Add missing functions to RunnerScript

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2054/#review2917 --- /trunk/KDE/kdelibs/plasma/abstractrunner.h

Re: Review Request: wetter.com Weather Ion

> On 2009-11-03 17:31:01, Will Stephenson wrote: > > You could work out the "Current Conditions" and "Condition Icon" data on > > each update using the current system time and the UTC time in the forecast > > periods, and set these on the data source. This would AFAICS get rid of > > the 'mis

Re: Firefox Bookmark runner

Am Dienstag 03 November 2009 21:12:23 schrieb Aaron J. Seigo: > On November 3, 2009, Jan Gerrit Marker wrote: > > Am Montag 02 November 2009 14:48:27 schrieb Sebastian Kügler: > > > If you've questions, you can just ask here > > > > And asking starts... > > Should the runner get the browser in the

thinking ahead to 4.5: features or polish?

hi all .. i spent some time today thinking about challenges as well as opportunities that exist for our little Plasma baby who is growing up at an amazing pace. just to give you an idea of where we're at in terms of raw code production, here are some sloccount counts: kdelibs: 42,121 runtime:

Re: Review Request: wetter.com Weather Ion

On Tuesday 03 November 2009, Thilo-Alexander Ginkel wrote: > On Tuesday 03 November 2009 18:51:05 Aaron Seigo wrote: > > > On 2009-11-03 17:00:51, Will Stephenson wrote: > > > > /trunk/kdereview/plasma/dataengines/weather/ions/ion_wettercom.cpp, > > > > line 44 > > > >

Re: Firefox Bookmark runner

On November 3, 2009, Jan Gerrit Marker wrote: > Ok, damn, I didn't think of that :( sorry > Thanks for the answer :) np, it's exactly why we have a mailing list and a whole bunch of crazy and/or smart people on it right? :) looking forward to seeing the bookmark runner kicking it up a notch in 4

Re: Review Request: wetter.com Weather Ion

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2026/ --- (Updated 2009-11-03 19:51:12.510139) Review request for kdelibs, Plasma and Shaw

Re: Firefox Bookmark runner

Am Montag 02 November 2009 14:48:27 schrieb Sebastian Kügler: > If you've questions, you can just ask here And asking starts... Should the runner get the browser in the constructor or the match() method? Some information about it: I store the QSqlDatabase in a variable m_db because this way I check

Re: thinking ahead to 4.5: features or polish?

2009/11/3 Aaron J. Seigo > hi all .. > > i spent some time today thinking about challenges as well as opportunities > that exist for our little Plasma baby who is growing up at an amazing pace. > > just to give you an idea of where we're at in terms of raw code production, > here are some sloccou

Re: Review Request: wetter.com Weather Ion

On Tuesday 03 November 2009 18:51:05 Aaron Seigo wrote: > > On 2009-11-03 17:00:51, Will Stephenson wrote: > > > /trunk/kdereview/plasma/dataengines/weather/ions/ion_wettercom.cpp, > > > line 44 > > > > > > > > > By conventi

Re: Review Request: Add missing functions to RunnerScript

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2054/ --- (Updated 2009-11-03 18:41:40.896958) Review request for Plasma. Changes --

Re: Firefox Bookmark runner

On November 3, 2009, Jan Gerrit Marker wrote: > Am Montag 02 November 2009 14:48:27 schrieb Sebastian Kügler: > > If you've questions, you can just ask here > > And asking starts... > Should the runner get the browser in the constructor or the match() method? in a slot connected to prepare() --

Re: Review Request: wetter.com Weather Ion

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2026/#review2904 --- You could work out the "Current Conditions" and "Condition Icon" data

Re: Review Request: plasmapkg & wallpaper

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2006/#review2908 --- Ship it! - Aaron On 2009-10-30 08:07:28, Petri Damstén wrote: > >

Re: Review Request: Add missing functions to RunnerScript

> On 2009-11-03 17:06:58, Aaron Seigo wrote: > > /trunk/KDE/kdelibs/plasma/scripting/runnerscript.h, lines 87-98 > > > > > > can't add new virtual members; it's BIC. the prepare and teardown slots > > are unecessary as th

Re: Review Request: Digital Clock applet date formatting

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1877/ --- (Updated 2009-11-04 01:05:16.263057) Review request for Plasma. Changes --

Re: Review Request: plasmapkg & wallpaper

> On 2009-11-03 17:07:50, Aaron Seigo wrote: > > /trunk/KDE/kdebase/runtime/plasma/tools/plasmapkg/main.cpp, lines 137-138 > > > > > > does this work for zip'd up packages as well? Plasma::PackageStructure reads metadata

Re: Review Request: Add missing functions to RunnerScript

> On 2009-11-03 17:06:58, Aaron Seigo wrote: > > /trunk/KDE/kdelibs/plasma/scripting/runnerscript.h, lines 87-98 > > > > > > can't add new virtual members; it's BIC. the prepare and teardown slots > > are unecessary as th

Re: Review Request: wetter.com Weather Ion

> On 2009-11-03 17:00:51, Will Stephenson wrote: > > /trunk/kdereview/plasma/dataengines/weather/ions/ion_wettercom.cpp, line 44 > > > > > > By convention, public member variables of pimpl classes are not names > > with m

Re: thinking ahead to 4.5: features or polish?

On November 3, 2009, Sean wrote: > I think this is a excellent idea for a number of reasons. It will shows > users that KDE4 is not just all about new features and more features and > more.. i'd like to make my position on this aspect of it perfectly clear: it is likely to be true that people

Re: Review Request: plasmapkg & wallpaper

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2006/#review2903 --- /trunk/KDE/kdebase/runtime/plasma/tools/plasmapkg/main.cpp

Re: Review Request: Add missing functions to RunnerScript

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2054/#review2902 --- /trunk/KDE/kdelibs/plasma/scripting/runnerscript.h

Re: Review Request: wetter.com Weather Ion

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2026/#review2901 --- /trunk/kdereview/plasma/dataengines/weather/ions/ion_wettercom.cpp

Re: Review Request: Add "reply" and "retweet" buttons in each tweet/dent of the microblog applet to quickly reply someone or retweet some message.

On Tuesday 03 November 2009, Nicolas Réau wrote: > > On 2009-11-02 17:34:56, Marco Martin wrote: > > > /trunk/KDE/kdeplasma-addons/applets/microblog/microblog.cpp, line 554 > > > > > > > > > everything in the tweetframe sho

Re: Review Request: Add "reply" and "retweet" buttons in each tweet/dent of the microblog applet to quickly reply someone or retweet some message.

> On 2009-11-02 17:34:56, Marco Martin wrote: > > /trunk/KDE/kdeplasma-addons/applets/microblog/microblog.cpp, line 554 > > > > > > everything in the tweetframe should become a single Anchorlayout. > > eventually after c

Review Request: Add missing functions to RunnerScript

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2054/ --- Review request for Plasma. Summary --- Add missing functions to RunnerScrip