Re: Firefox Bookmark runner

2009-11-01 Thread Eduardo Robles Elvira
On Sun, Nov 1, 2009 at 11:33 AM, Jan Gerrit Marker wrote: > Hello, > today I moved a runner called "Firefox Bookmarks" to playground. This runner > allows you to search through the bookmarks of the default Firefox profile. In > order to get enough time to add it to KDE 4.4 I want to add it to the

Re: Review Request: Comic applet proted to PopupApplet

2009-11-01 Thread Giulio Camuffo
In data sabato 31 ottobre 2009 10:11:47, Marco Martin ha scritto: : > On Saturday 31 October 2009, Aaron J. Seigo wrote: > > On October 30, 2009, Giulio Camuffo wrote: > > > In data venerdì 30 ottobre 2009 18:03:07, Aaron J. Seigo ha scritto: > > > : > On October 30, 2009, Giulio Camuffo wrote: > >

Re: Review Request: wetter.com Weather Ion

2009-11-01 Thread Thilo-Alexander Ginkel
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2026/ --- (Updated 2009-11-01 18:31:18.178318) Review request for kdelibs, Plasma and Shaw

Re: Review Request: Add a tooltip to battery monitor applet

2009-11-01 Thread Sebastian Kügler
On Sunday 01 November 2009 10:34:16 Kåre Särs wrote: > I'm not running trunk, so I had to comment out the setStatus() functions > (not done in the patch). If you're not, you patch is likely to not apply. I've been re-working the layout of the popup dialog, but I'm not finished with it yet. --

Re: Review Request: wetter.com Weather Ion

2009-11-01 Thread Thilo-Alexander Ginkel
> On 2009-10-31 18:48:39, Armin Berres wrote: > > /trunk/kdereview/plasma/dataengines/weather/ions/ion_wettercom.h, line 146 > > > > > > Nitpicking: What about fetchForecast instead of getForecast? When I > > looked at t

Re: Review Request: wetter.com Weather Ion

2009-11-01 Thread Thilo-Alexander Ginkel
> On 2009-11-01 08:46:19, Will Stephenson wrote: > > I don't see a reason for the first leak you highlight in your code. You > > should create the url using QLatin1String as this saves QString having to > > guess the encoding -see > > http://labs.trolltech.com/blogs/2008/04/28/string-theory/

Firefox Bookmark runner

2009-11-01 Thread Jan Gerrit Marker
Hello, today I moved a runner called "Firefox Bookmarks" to playground. This runner allows you to search through the bookmarks of the default Firefox profile. In order to get enough time to add it to KDE 4.4 I want to add it to the feature plan. Is the runner ok? Is it ok, if I add it to the fea

Re: Review Request: wetter.com Weather Ion

2009-11-01 Thread Will Stephenson
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2026/#review2882 --- I don't see a reason for the first leak you highlight in your code. Y

Re: Review Request: Add a tooltip to battery monitor applet

2009-11-01 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2010/ --- (Updated 2009-11-01 09:34:16.376436) Review request for Plasma. Changes --

Re: Review Request: Add a tooltip to battery monitor applet

2009-11-01 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2010/ --- (Updated 2009-11-01 08:04:09.930792) Review request for Plasma. Changes --

Re: Review Request: wetter.com Weather Ion

2009-11-01 Thread Will Stephenson
On 2009-10-31 18:48:39, Thilo-Alexander Ginkel wrote: > > Oh, and personally I would use some kind of shared pointer for the > > WeatherData::Forecast[Period|INFO]* objects. But this is just something > > personal. I try to avoid memory I have to delete explicitly these days. When I search for