Re: Review Request: 'Next image' action for image plugin (and wallpaper contextual actions) - kdebase diff

2009-10-12 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1822/#review2624 --- Ship it! /trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/imag

Re: Review Request: Plasma + Qt Kinetic GSoC Project - Attempt 2

2009-10-12 Thread Adenilson Cavalcanti
> On 2009-09-21 16:26:17, Aaron Seigo wrote: > > any updates on this? Richard's comments don't seem to be addressed yet. Aaron is it possible to add my user in the list so I can upload an updated patch? - Adenilson --- This is an autom

Re: Review Request: 'Next image' action for image plugin (and wallpaper contextual actions) - kdelibs diff

2009-10-12 Thread Yuen Hoe Lim
> On 2009-10-12 20:12:52, Chani wrote: > > /trunk/KDE/kdelibs/plasma/wallpaper.cpp, line 424 > > > > > > looks good... but I wonder, will wallpapers want to change their > > actions when constraints change? will any wall

Re: Review Request: 'Next image' action for image plugin (and wallpaper contextual actions) - kdebase diff

2009-10-12 Thread Yuen Hoe Lim
> On 2009-10-12 20:08:28, Chani wrote: > > /trunk/KDE/kdebase/workspace/plasma/generic/containmentactions/contextmenu/menu.cpp, > > line 194 > > > > > > iirc this is going to leak. > > what I did for other separators

Re: activities overview, take N

2009-10-12 Thread Chani
> > > > > * a "New Activity" tab would appear Active and Stored and would allow > > > you to create a new activity, including picking what kind of activity > > > and optionally what other activity you would like to clone > > > > interesting. I ended up going with the "don't force any decisions, ju

Re: activities overview, take N

2009-10-12 Thread Chani
> > > perhaps even in the pager itself, an extra button that disappears on > > > desktop effects off or if there is not the proper atom set (i.e. > > > compiz) > > > > hmm. where in the pager? :) > > bah, just a button in an horizontal layout with the current pager? then you'd have to change it

Review Request: Fix several kdelibs/plasma issues reported by krazy2 and some compiler warnings

2009-10-12 Thread Darío Andrés
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1837/ --- Review request for Plasma. Summary --- A bunch of small fixes reported by K

Re: activities overview, take N

2009-10-12 Thread Marco Martin
On Monday 12 October 2009, Chani wrote: > > > * in the same panel controller window that we now show the Add Widgets > > > interface, we could show a Choose Activity interface. it would share a > > > lot of presentation code with Add Widgets for consistency. > > > > so just a list of thumbnails? >

Re: activities overview, take N

2009-10-12 Thread Marco Martin
On Monday 12 October 2009, Chani wrote: > > so what's wrong with the overview thing in gnome-shell? in one word: it's > > modal. > > now that I think about it, that's part of what was wrong with the zui too. > > > applications would get little dummy representations of themselves drawn > > in litt

Re: Review Request: 'Next image' action for image plugin (and wallpaper contextual actions) - kdelibs diff

2009-10-12 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1821/#review2620 --- Ship it! +1 :) /trunk/KDE/kdelibs/plasma/wallpaper.cpp

Re: Review Request: 'Next image' action for image plugin (and wallpaper contextual actions) - kdebase diff

2009-10-12 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1822/#review2619 --- /trunk/KDE/kdebase/workspace/plasma/generic/containmentactions/contex

Re: activities overview, take N

2009-10-12 Thread Chani
> > > > * in the same panel controller window that we now show the Add Widgets > > interface, we could show a Choose Activity interface. it would share a > > lot of presentation code with Add Widgets for consistency. > > so just a list of thumbnails? could be. since it's not modal, if you wanted

Re: activities overview, take N

2009-10-12 Thread Chani
> > Maybe not exactly related to this thread, but still something I'd like to > mention- > The concept of virtual desktops and activities being separate is something > I've seen beginners feel rather confusing. Seeing the word "desktop", it > gives the impression of desktop=wallpaper+applets and

Re: activities overview, take N

2009-10-12 Thread Chani
> so what's wrong with the overview thing in gnome-shell? in one word: it's > modal. now that I think about it, that's part of what was wrong with the zui too. > > applications would get little dummy representations of themselves drawn in > little boxes. i kept thinking "this is really just ano